Implement events and event handlers (similar to RxInfer) by bvdmitri · Pull Request #575 · ReactiveBayes/ReactiveMP.jl

bvdmitri · 2026-03-09T09:11:32Z

This (draft) PR implements events and event handlers, which would be useful to observe the inference procedure inside ReactiveMP. Part of ReactiveBayes/RxInfer.jl#566

Introduce a new event handler mechanism that allows users to hook into the message passing procedure via `Event`, `handle_event`, and `broadcast_event` functions. Events are broadcast before and after message rule calls, enabling debugging and monitoring capabilities. Key changes: - Add `event_handler.jl` with event types and handler interfaces - Extend `MessageMapping` to include an event handler parameter - Support both custom handler types and NamedTuple-based handlers - Add documentation for the events system - Include comprehensive tests for event handler functionality

github-actions · 2026-03-09T09:13:14Z

🤖 Code Formatting

Your PR still has some code formatting issues. I've updated PR #576 with the necessary formatting changes.

You can merge that PR into this branch to fix the code style check.

Alternatively, you can run make format locally and push the changes yourself.

github-actions · 2026-03-09T09:27:07Z

🤖 Code Formatting

Your PR still has some code formatting issues. I've updated PR #576 with the necessary formatting changes.

You can merge that PR into this branch to fix the code style check.

Alternatively, you can run make format locally and push the changes yourself.

codecov · 2026-03-09T09:38:06Z

Codecov Report

❌ Patch coverage is 93.02326% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.66%. Comparing base (dc924fe) to head (1c08d09).

Files with missing lines	Patch %	Lines
src/message.jl	90.69%	4 Missing ⚠️
src/nodes/predefined/delta/delta.jl	0.00%	1 Missing ⚠️
src/variables/data.jl	83.33%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #575      +/-   ##
==========================================
+ Coverage   80.36%   80.66%   +0.29%     
==========================================
  Files         211      212       +1     
  Lines        6388     6435      +47     
==========================================
+ Hits         5134     5191      +57     
+ Misses       1254     1244      -10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

github-actions · 2026-03-09T10:34:09Z

🤖 Code Formatting

Your PR still has some code formatting issues. I've updated PR #577 with the necessary formatting changes.

You can merge that PR into this branch to fix the code style check.

Alternatively, you can run make format locally and push the changes yourself.

github-actions · 2026-03-09T12:10:26Z

🤖 Code Formatting

Your PR still has some code formatting issues. I've updated PR #577 with the necessary formatting changes.

You can merge that PR into this branch to fix the code style check.

Alternatively, you can run make format locally and push the changes yourself.

github-actions · 2026-03-10T07:34:24Z

🤖 Code Formatting

Your PR still has some code formatting issues. I've updated PR #578 with the necessary formatting changes.

You can merge that PR into this branch to fix the code style check.

Alternatively, you can run make format locally and push the changes yourself.

this is required to inject the callbacks properly, plus we do the breaking release already. Could break (and improve) more things as well then

github-actions · 2026-03-16T09:19:21Z

🤖 Code Formatting

Your PR still has some code formatting issues. I've updated PR #581 with the necessary formatting changes.

You can merge that PR into this branch to fix the code style check.

Alternatively, you can run make format locally and push the changes yourself.

github-actions · 2026-03-16T09:53:51Z

🤖 Code Formatting

Your PR still has some code formatting issues. I've updated PR #581 with the necessary formatting changes.

You can merge that PR into this branch to fix the code style check.

Alternatively, you can run make format locally and push the changes yourself.

github-actions · 2026-03-16T10:09:43Z

🤖 Code Formatting

Your PR still has some code formatting issues. I've updated PR #581 with the necessary formatting changes.

You can merge that PR into this branch to fix the code style check.

Alternatively, you can run make format locally and push the changes yourself.

github-actions · 2026-03-16T10:14:22Z

🤖 Code Formatting

Your PR still has some code formatting issues. I've updated PR #581 with the necessary formatting changes.

You can merge that PR into this branch to fix the code style check.

Alternatively, you can run make format locally and push the changes yourself.

github-actions · 2026-03-19T07:30:34Z

🤖 Code Formatting

Your PR still has some code formatting issues. I've updated PR #581 with the necessary formatting changes.

You can merge that PR into this branch to fix the code style check.

Alternatively, you can run make format locally and push the changes yourself.

- `compute_product_of_messages` now accepts the `AbstractVariable`, makes it easier to identify the variable inside the callback

github-actions · 2026-03-19T08:46:57Z

🤖 Code Formatting

Your PR still has some code formatting issues. I've updated PR #586 with the necessary formatting changes.

You can merge that PR into this branch to fix the code style check.

Alternatively, you can run make format locally and push the changes yourself.

github-actions · 2026-03-19T08:51:48Z

🤖 Code Formatting

Your PR still has some code formatting issues. I've updated PR #586 with the necessary formatting changes.

You can merge that PR into this branch to fix the code style check.

Alternatively, you can run make format locally and push the changes yourself.

github-actions · 2026-03-19T08:52:58Z

🤖 Code Formatting

Your PR still has some code formatting issues. I've updated PR #586 with the necessary formatting changes.

You can merge that PR into this branch to fix the code style check.

Alternatively, you can run make format locally and push the changes yourself.

github-actions · 2026-03-19T09:09:34Z

🤖 Code Formatting

Your PR still has some code formatting issues. I've updated PR #586 with the necessary formatting changes.

You can merge that PR into this branch to fix the code style check.

Alternatively, you can run make format locally and push the changes yourself.

… constraints

github-actions · 2026-03-19T09:57:07Z

🤖 Code Formatting

Your PR still has some code formatting issues. I've updated PR #586 with the necessary formatting changes.

You can merge that PR into this branch to fix the code style check.

Alternatively, you can run make format locally and push the changes yourself.

github-actions · 2026-03-19T10:13:30Z

🤖 Code Formatting

Your PR still has some code formatting issues. I've updated PR #586 with the necessary formatting changes.

You can merge that PR into this branch to fix the code style check.

Alternatively, you can run make format locally and push the changes yourself.

github-actions · 2026-03-19T10:27:37Z

🤖 Code Formatting

Your PR still has some code formatting issues. I've updated PR #586 with the necessary formatting changes.

You can merge that PR into this branch to fix the code style check.

Alternatively, you can run make format locally and push the changes yourself.

github-actions · 2026-03-19T10:48:57Z

🤖 Code Formatting

Your PR still has some code formatting issues. I've updated PR #586 with the necessary formatting changes.

You can merge that PR into this branch to fix the code style check.

Alternatively, you can run make format locally and push the changes yourself.

bvdmitri · 2026-03-19T11:46:29Z

I will close for now as the spam from formatter is a bit annoying

bvdmitri added 2 commits March 5, 2026 15:15

type in docstring

ea3b6dc

inject the event handler in the factor node activation options

eea47c8

bvdmitri added 2 commits March 9, 2026 10:45

make format

74b57a1

document the existing events better

3babdbe

bvdmitri added 2 commits March 9, 2026 13:07

rename event handler to callbacks to better match RxInfer

083f798

update docs

4488d79

bvdmitri added 5 commits March 9, 2026 13:31

use make format

eedd31d

fix typo

32ff1b6

allow to merge callbacks

d6aafa6

allow reduce the result of the callbacks

6b6a1d4

add per-event callback reducer

b77cae2

bvdmitri added 3 commits March 10, 2026 08:56

make format

4a9e28a

remove test method

99fc25e

start reimplement of the product of two messages

9bd5c18

this is required to inject the callbacks properly, plus we do the breaking release already. Could break (and improve) more things as well then

bvdmitri added 2 commits March 16, 2026 10:49

fix initial integration with RxInfer.jl

b264145

fix Aqua tests

14c1925

caught a small bug in RxInfer tests

483c59a

caught another bug from RxInfer.jl tests

1ee727d

Merge branch 'main' into callbacks

d24879b

bvdmitri added 3 commits March 19, 2026 08:36

Merge branch 'main' into callbacks

629295f

merge stricter formatting

42e92c1

Refactor the variables, add docstrings, add labels

41d6032

- `compute_product_of_messages` now accepts the `AbstractVariable`, makes it easier to identify the variable inside the callback

fix documentation build

3f6d2d2

2prev

c65d2c4

add before/after product of two messages callbacks

2d38c63

bvdmitri added 2 commits March 19, 2026 10:20

fix failing tests

bf495be

add before/after product of messages callbacks. add before/after form…

5a39369

… constraints

add before/after marginal compute callbacks

609f466

add error hint in case of wrong passed callbacks

aec5de0

fix test

1c08d09

bvdmitri closed this Mar 19, 2026

Conversation

bvdmitri commented Mar 9, 2026

Uh oh!

github-actions bot commented Mar 9, 2026

🤖 Code Formatting

Uh oh!

github-actions bot commented Mar 9, 2026

🤖 Code Formatting

Uh oh!

codecov bot commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Mar 9, 2026

🤖 Code Formatting

Uh oh!

github-actions bot commented Mar 9, 2026

🤖 Code Formatting

Uh oh!

github-actions bot commented Mar 10, 2026

🤖 Code Formatting

Uh oh!

github-actions bot commented Mar 16, 2026

🤖 Code Formatting

Uh oh!

github-actions bot commented Mar 16, 2026

🤖 Code Formatting

Uh oh!

github-actions bot commented Mar 16, 2026

🤖 Code Formatting

Uh oh!

github-actions bot commented Mar 16, 2026

🤖 Code Formatting

Uh oh!

github-actions bot commented Mar 19, 2026

🤖 Code Formatting

Uh oh!

github-actions bot commented Mar 19, 2026

🤖 Code Formatting

Uh oh!

github-actions bot commented Mar 19, 2026

🤖 Code Formatting

Uh oh!

github-actions bot commented Mar 19, 2026

🤖 Code Formatting

Uh oh!

github-actions bot commented Mar 19, 2026

🤖 Code Formatting

Uh oh!

github-actions bot commented Mar 19, 2026

🤖 Code Formatting

Uh oh!

github-actions bot commented Mar 19, 2026

🤖 Code Formatting

Uh oh!

github-actions bot commented Mar 19, 2026

🤖 Code Formatting

Uh oh!

github-actions bot commented Mar 19, 2026

🤖 Code Formatting

Uh oh!

bvdmitri commented Mar 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

codecov bot commented Mar 9, 2026 •

edited

Loading