Fix shift value for confidence interval#202
Open
StephenNneji wants to merge 2 commits intoRascalSoftware:mainfrom
Open
Fix shift value for confidence interval#202StephenNneji wants to merge 2 commits intoRascalSoftware:mainfrom
StephenNneji wants to merge 2 commits intoRascalSoftware:mainfrom
Conversation
StephenNneji
force-pushed
the
fix_scale_again
branch
from
d9b1b99 to
0ea7df6
Compare
DrPaulSharp
reviewed
Mar 19, 2026
Collaborator
There was a problem hiding this comment.
I see that this change is to match up the shift used for the confidence intervals with the one used for the data elsewhere in the plotting module. However, I'm not sure that the "+1" is right here. For the first four values of i, with a shift_value of 100, we have div = 1, 100, 1000, 10000 - i.e., the factor 10 is missing. Looking at a plot of the current behaviour, for the second contrast the current behaviour gives the shown confidence region, whist this change gives the data. What do you think?
Collaborator
|
I can confirm the same bug is in the matlab - it should be |
StephenNneji
force-pushed
the
fix_scale_again
branch
from
a79f6ae to
9c0508b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I missed fixing shift value on confidence interval