Update Portuguese translations and Added new ARCs and their image assets

[uilson]

Refine Portuguese (pt) localization: extensive wording, terminology and consistency updates in arctracker-ui/pt.json

Add bot images (images/bots/arc_comet.png, images/bots/arc_firefly.png) (temporarily using the wiki ones).

Update supporting data files (bots.json, maps.json, missingitems_ingame.md, projects.json).

Update .gitignore to include update_missing_items.py (this is a script on my side that checks for the images on the ingame_items and removes the entry from the list in the missing items file, dont worry about it) and normalize node_modules entry.

[uilson]

missunderstud the last update meaning, fixed on last commit

[baschny]

@uilson suggestion: Separate the pull requests my topic, so that they are not mixed together and can also be reviewed and merged separately.

The game itself unfortunately does not have a "Portuguese (Portugal)" variant, so all in game translations for pt-PT are the same as the pt-BR (quests, projects). But its cool that you "portuguesed" the ones in the UI!

I would also not add you own private requirements (gitignoring your scripts). My suggestion (which is how I do it), is to keep your scripts in a separate directory (i.e. ../arcraiders-data-myscript/), so you dont need to gitignore them. I even version this separate directory on its own.

Doing this would improve the chance of it getting added more easily by the maintainers.

[uilson]

The game itself unfortunately does not have a "Portuguese (Portugal)" variant, so all in game translations for pt-PT are the same as the pt-BR (quests, projects). But its cool that you "portuguesed" the ones in the UI!

yes the game it self doesn't have Portuguese from Portugal, the changes I did to the maps file are minor, just correction of "something_something" to "Something Something" and the ocasional change to the correct Portuguese from PT translation.

I made that changes because the majority of Portuguese people although they play with the game in English (many of us dont usually go with pt-br even if its available, as its not our language), when they use a website that says Portuguese from Portugal, are expecting it to be Portuguese from Portugal, not a mix of both Portuguese from Brazil and from Portugal.
if we play in english and use the website in Portuguese, we are translating to our language and them looking for it, so it doesnt make sense to have Portuguese from Brazil there.

In my opinion, you either have it, or you dont.
Having the PT option (when its not in the game) and have it be pt-BR, doesnt make sense, if its in the files it deserves to be correctly translated.

I would also not add you own private requirements (gitignoring your scripts). My suggestion (which is how I do it), is to keep your scripts in a separate directory (i.e. ../arcraiders-data-myscript/), so you dont need to gitignore them. I even version this separate directory on its own.

Yes i would agree with this, but this doesn't really matter, as no one have node_modules in the repo and yet its there. And I would gladly make that script available as its nothing special, just string looking and removing.

[baschny]

In my opinion, you either have it, or you dont. Having the PT option (when its not in the game) and have it be pt-BR, doesnt make sense, if its in the files it deserves to be correctly translated.

I think you misunderstood me, I think your changes are good! I was just explaining that the in-game strings come directly from the game, and we don't have the pt-PT variants of them, so they are just copied from the pt-BR ones. For the site we are free to use your variants!

I would also not add you own private requirements (gitignoring your scripts). My suggestion (which is how I do it), is to keep your scripts in a separate directory (i.e. ../arcraiders-data-myscript/), so you dont need to gitignore them. I even version this separate directory on its own.

Yes i would agree with this, but this doesn't really matter, as no one have node_modules in the repo and yet its there.

We have a prettier config (since #189) in the repo which uses node modules (see README.md and packages.json) to reformat the json files. This is in the repo, so the node_modules (which is created if you run bun install) is needed in .gitignore.

[uilson]

No, i understood you, but like i said, if you add Portuguese to the translations list from the game even though they dont really exist in the game, they should be Portuguese, not Portuguese from Brazil.

It defeats the purpose of adding the PT translation, if you just keeping it the same as the pt-BR.

We have a prettier config (since #189) in the repo which uses node modules (see README.md and packages.json) to reformat the json files. This is in the repo, so the node_modules (which is created if you run bun install) is needed in .gitignore.

As for the node_modules i stand correct, i had not noticed the bun module, i been away dealing with real life things and didnt noticed the addition of the bun module.

[baschny]

i been away dealing with real life things and didnt noticed the addition of the bun module.

I see you have contributed a lot in the past, glad you are back. I am not the maintainer of this, maybe @mattmarcin can merge this so that we can move forward on this.

[uilson]

@mattmarcin is there any reason for the ordering of the the EN language not matching the rest of the translation files?

My translation was a clean one based on the EN file, i ditched the old PT that was a copy of pt-BR and made one from scratch. with this last commit from you, it created innumerous conflicts because for some reason the array's structure does not match the EN file, so im assuming the old PT one also did not match.

for example: on the EN file you have the "ItemTooltip" like this:

      "tooltipThisWeek": "This week",
      "tooltipWeeksAgo": "{count}w ago",
      "reliability": {
        "insufficient": "Insufficient Data",
        "insufficientDesc": "Less than 10 raids tracked",
        "low": "Limited Data",
        "lowDesc": "10-49 raids tracked",
        "medium": "Good Reliability",
        "mediumDesc": "50-199 raids tracked",
        "high": "Excellent Reliability",
        "highDesc": "200+ raids tracked"
      }
    }
  },
  "ItemTooltip": {
    "onYourLists": "On Your Lists",
    "tapToView": "Tap again to view details"
  },

but on the PT with the changes its like this, sending the "ItemTooltip", to the very end of the file together with the new Cipher translations:

      "reliability": {
        "insufficient": "Dados Insuficientes",
        "insufficientDesc": "Menos de 10 incursões rastreadas",
        "low": "Dados Limitados",
        "lowDesc": "10-49 incursões rastreadas",
        "medium": "Boa Confiabilidade",
        "mediumDesc": "50-199 incursões rastreadas",
        "high": "Excelente Confiabilidade",
        "highDesc": "200+ incursões rastreadas"
      },
      "tooltipThisWeek": "Esta semana",
      "tooltipWeeksAgo": "{count} sem. atrás"
    },

will do a new file based on the EN again in order to have consistency between files.

[mattmarcin]

@uilson I try my best not to change ordering but a ton of keys were added. There is currently no key ordering in place. Thinking its needed at this point.

[uilson]

new translation file has been added, it still conflicts as this new one matches the en.json key orders, so it is noticing the difference on the keys order.

[uilson]

any revision about this?