Skip to content

Create execute_ci_build_upstream.s#759

Open
leo-amd wants to merge 7 commits intorocm-dev-infrafrom
leo/upstream-script
Open

Create execute_ci_build_upstream.s#759
leo-amd wants to merge 7 commits intorocm-dev-infrafrom
leo/upstream-script

Conversation

@leo-amd
Copy link
Collaborator

@leo-amd leo-amd commented Mar 25, 2026

No description provided.

@i-chaochen i-chaochen requested a review from alekstheod March 25, 2026 16:29
"-//xla/backends/gpu/runtime:all_reduce_test_amdgpu_any"
"-//xla/tests:collective_ops_e2e_test_amdgpu_any"
"-//xla/tests:collective_ops_test_amdgpu_any"
"-//xla/tools/multihost_hlo_runner:functional_hlo_runner_test_amdgpu_any"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zoranjovanovic-ns IIUC, we skip these tests due to openxla#39373 ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial reason for creating openxla#39373 was failing //xla/service/gpu:float_support_test. Test itself start passing after hipblaslt was disabled on upstream, thus new test case was added to ‎xla/backends/gpu/transforms/gemm_rewriter.cc in PR.

Copy link
Collaborator

@i-chaochen i-chaochen Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but upstream has enabled "hipblaslt" 2 days ago openxla@ba4f5f2 you mean because of this?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but upstream has enabled "hipblaslt" 2 days ago openxla@ba4f5f2 you mean because of this?

hipblaslt is re-enabled, thus openxla#39373 might be necessary for //xla/service/gpu:float_support_test test to pass on MI200.
I did not saw relation of that PR to remaining tests from the list.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a way we want to skip the tests. Check our current script. It uses --test_filter.
Lets use that mechanism instead

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also upstream we have just 1 failing test but here we have to exclude quite some of them. Some configs must be missing.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll rewire

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants