Merged
Conversation
…ning containers in bash
Collaborator
|
Created a separate story to address:
|
Collaborator
Author
|
! cherry-pick --onto release/1.8.0 |
rocm-repo-management-api-6 bot
pushed a commit
that referenced
this pull request
Mar 17, 2026
* Added GHA CI workflow * Change target branch * Update naming * ci: trigger actions * Move the file * Setup python env * Use containers * These k8s runners don't support native containers, therefore I am running containers in bash * Typo * Fix git dubious ownership * Git fixes * Typo * Cmake change * requirements.txt fix * Clone in container * Resolve latest PyTorch main SHA * Rewrite from scratch * Set rocm * Add sanity check * set -euxo pipefail * typo * Rewritten * Fix tests * Set large timeout for tests * Split the steps * Implement discussed features * Fix tests * Fix tests more * Try tests * Removed the HIP_VISIBLE_DEVICES code * Lock the RCCL context * Force CPU to wait for the GPUs, and we need to force all GPUs to wait for each other before anyone is allowed to reset the memory pool * Revert * Resolve comments * Hausekepping * Run CI * Propagate import errors * Extension tests fix * Apply launch bounds unconditionally * Define USE_ROCM during JIT compilation * Revert some changes * Resolve comments * Fix typo
|
Created branch autogenerated/release/1.8.0_cherry-pick_pr-303 and #317 Comment processed by Build |
Collaborator
Author
|
! cherry-pick --onto release/1.9.0 |
rocm-repo-management-api-6 bot
pushed a commit
that referenced
this pull request
Mar 18, 2026
* Added GHA CI workflow * Change target branch * Update naming * ci: trigger actions * Move the file * Setup python env * Use containers * These k8s runners don't support native containers, therefore I am running containers in bash * Typo * Fix git dubious ownership * Git fixes * Typo * Cmake change * requirements.txt fix * Clone in container * Resolve latest PyTorch main SHA * Rewrite from scratch * Set rocm * Add sanity check * set -euxo pipefail * typo * Rewritten * Fix tests * Set large timeout for tests * Split the steps * Implement discussed features * Fix tests * Fix tests more * Try tests * Removed the HIP_VISIBLE_DEVICES code * Lock the RCCL context * Force CPU to wait for the GPUs, and we need to force all GPUs to wait for each other before anyone is allowed to reset the memory pool * Revert * Resolve comments * Hausekepping * Run CI * Propagate import errors * Extension tests fix * Apply launch bounds unconditionally * Define USE_ROCM during JIT compilation * Revert some changes * Resolve comments * Fix typo
|
Created branch autogenerated/release/1.9.0_cherry-pick_pr-303 and #318 Comment processed by Build |
Collaborator
Author
|
! cherry-pick --onto release/1.10.0 |
rocm-repo-management-api-6 bot
pushed a commit
that referenced
this pull request
Mar 18, 2026
* Added GHA CI workflow * Change target branch * Update naming * ci: trigger actions * Move the file * Setup python env * Use containers * These k8s runners don't support native containers, therefore I am running containers in bash * Typo * Fix git dubious ownership * Git fixes * Typo * Cmake change * requirements.txt fix * Clone in container * Resolve latest PyTorch main SHA * Rewrite from scratch * Set rocm * Add sanity check * set -euxo pipefail * typo * Rewritten * Fix tests * Set large timeout for tests * Split the steps * Implement discussed features * Fix tests * Fix tests more * Try tests * Removed the HIP_VISIBLE_DEVICES code * Lock the RCCL context * Force CPU to wait for the GPUs, and we need to force all GPUs to wait for each other before anyone is allowed to reset the memory pool * Revert * Resolve comments * Hausekepping * Run CI * Propagate import errors * Extension tests fix * Apply launch bounds unconditionally * Define USE_ROCM during JIT compilation * Revert some changes * Resolve comments * Fix typo
|
Created branch autogenerated/release/1.10.0_cherry-pick_pr-303 and #319 Comment processed by Build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing:
Build job: https://github.com/ROCm/apex/actions/runs/22921037182/job/66569521660?pr=303
Test job: https://github.com/ROCm/apex/actions/runs/22921037182/job/66569521362?pr=303
Cherry-picked to release/1.8.0 branch via #317
Cherry-picked to release/1.9.0 branch via #318
Cherry-picked to release/1.10.0 branch via #319