feat(cli): add startup optimization with API preconnect and early input capture#3085
Open
feat(cli): add startup optimization with API preconnect and early input capture#3085
Conversation
…ut capture Implements #3011 startup optimization with two key features: 1. API Preconnect - Warms TCP+TLS connection before first API call - Fire-and-forget HEAD request to reduce first API call latency - Smart skip conditions: proxy, custom CA, sandbox mode, custom baseUrl - Environment variable toggle: QWEN_CODE_DISABLE_PRECONNECT=1 2. Early Input Capture - Captures user input during REPL initialization - Filters terminal responses (DA, DA2, OSC, DCS) while preserving user input - Preserves arrow keys (ESC [ A/B/C/D) and function keys (F1-F4) - 64KB buffer limit for safety - Environment variable toggle: QWEN_CODE_DISABLE_EARLY_CAPTURE=1 Benchmark results: - TCP+TLS handshake time: 181ms → 56ms (69% improvement) - First API call latency: estimated 100-200ms reduction
Contributor
📋 Review SummaryThis PR implements startup optimization with two key features: API preconnect (warming TCP+TLS connections before the first API call) and early input capture (preventing keystroke loss during REPL initialization). The implementation is well-structured with comprehensive test coverage (34 tests total), thoughtful skip conditions, and environment variable toggles for both features. The code demonstrates good engineering practices with proper error handling and debug logging. 🔍 General Feedback
🎯 Specific Feedback🟡 High
🟢 Medium
🔵 Low
✅ Highlights
|
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
doudouOUC
requested review from
DennisYu07,
chiga0,
jifeng,
wenshao and
yiliang114
wenshao
reviewed
Apr 10, 2026
packages/cli/src/gemini.tsx
Outdated
| const probableAuthType = | ||
| process.env['QWEN_CODE_AUTH_TYPE'] || | ||
| (settings.merged.security?.auth?.selectedType as string | undefined); | ||
| preconnectApi(probableAuthType, { |
Collaborator
There was a problem hiding this comment.
[Suggestion] preconnectApi() now runs before argument parsing and command dispatch, so local-only flows like --help and --version can still trigger an outbound HEAD request even though this process will never make an API call. Please move the preconnect trigger until after mode/argv selection and only fire it for flows that are actually about to perform API-backed work.
— gpt-5.4 via Qwen Code /review
|
|
||
| // 2. 从环境变量获取 | ||
| const envBaseUrl = | ||
| process.env['OPENAI_BASE_URL'] || |
Collaborator
There was a problem hiding this comment.
[Suggestion] The environment override lookup uses a fixed OPENAI_BASE_URL || ANTHROPIC_BASE_URL || GEMINI_BASE_URL order and does not consult the active authType. In mixed-provider environments this can warm the wrong vendor endpoint. Please resolve the env override according to the selected auth type instead of scanning all provider env vars globally.
— gpt-5.4 via Qwen Code /review
| return false; | ||
| } | ||
|
|
||
| const nextByte = data[nextIdx]; |
Collaborator
There was a problem hiding this comment.
[Suggestion] This branch treats any ESC ], ESC P, ESC ^, or ESC _ prefix as a terminal response immediately. Those prefixes can also represent legitimate Meta/Alt-prefixed user input, so some startup keystrokes can still be discarded before the normal keypress parser sees them. Please only strip these sequences after recognizing a complete terminal-response frame, or defer ambiguous ESC-prefixed input to the normal keypress path.
— gpt-5.4 via Qwen Code /review
1. Move preconnect after loadCliConfig to avoid unnecessary HEAD requests for --help/--version flows 2. Lookup env baseUrl based on authType instead of fixed order 3. Translate Chinese comments to English for consistency 4. Add try-catch for preconnect call to handle missing getModelsConfig Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Author
回复 @wenshao 的评论评论 1: preconnect 时机问题 ✅ 已修复
修复方案: 将 preconnect 移到 评论 2: 环境变量查找顺序问题 ✅ 已修复
修复方案: 根据 authType 查找对应的环境变量：
评论 3: ESC 序列过滤问题 ❌ 不采纳
说明: 这些是标准控制序列起始符（OSC/DCS/PM/APC），在终端协议中永远不会是用户输入。用户 Meta/Alt 组合键是 Commit: 00749d4 |
- Update copyright from 'Google LLC' to 'Qwen Team' - Translate all Chinese comments to English for consistency
doudouOUC
removed request for
DennisYu07,
chiga0,
jifeng,
pomelo-nwu,
tanzhenxin,
wenshao and
yiliang114
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #3011 startup optimization with two key features:
1. API Preconnect
QWEN_CODE_DISABLE_PRECONNECT=12. Early Input Capture
QWEN_CODE_DISABLE_EARLY_CAPTURE=1Benchmark Results
Test Plan
🤖 Generated with Claude Code