Conversation
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
lkdvos
left a comment
There was a problem hiding this comment.
Would it be possible to refactor the test suite so we can actually reuse it? It's really not the goal to have to copy that code, the point of the suite was to be able to reuse it
lkdvos
left a comment
There was a problem hiding this comment.
I think you are missing a slight formatting issue in the categories.jl file (newline at the end), and I left some minor comments. Otherwise good to go for me as soon as the TensorKitSectors changes are released
Codecov Report❌ Patch coverage is
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
I'm really confused with the test fail, I thought the point of QuantumKitHub/TensorKitSectors.jl#77 was to capture this? Either way, it seems the error for |
|
Well, it wasn't running the testsuite yet since you are adding that in this PR, the downstream tests are only attempted on the latest release |
|
I seem to have already noticed in QuantumKitHub/TensorKitSectors.jl#59 that certain sectors weren't passing the Artin braid test, and kind of forgot about that 🫠 I've locally tested which braided categories fail the test, of which there are 9 which can be grouped into 4 with different F and R solutions. I'm trying to guess which categories these are, and comparing with the anyonwiki to perhaps make sense of these. Edit: Let me mention the 4 grouped up categories and what I think they represent here. I'll drop the
So yeah, not sure really where to go with this at this point. Maybe just wait till we read in the new data? |
TKS 0.3.6 improved on the test suite.
Sadly we can't just blindly import that because of the use of sparse arrays here, so multiple tests are actually not brought over.I'm also not sure of how much is being doubly tested. I wrote the tests assuming every fusion category is not in the braided list and vice versa.
Edit: This requires a new version release of TKS (QuantumKitHub/TensorKitSectors.jl#70)