bar_index extra handling? Just for your consideration. #139#146
Open
dcaoyuan wants to merge 1 commit intoQuantForgeOrg:mainfrom
Open
bar_index extra handling? Just for your consideration. #139#146dcaoyuan wants to merge 1 commit intoQuantForgeOrg:mainfrom
dcaoyuan wants to merge 1 commit intoQuantForgeOrg:mainfrom
Conversation
dcaoyuan
force-pushed
the
bar_index-question
branch
from
5041b4a to
94b86c1
Compare
dcaoyuan
force-pushed
the
bar_index-question
branch
from
94b86c1 to
07fafdd
Compare
Collaborator
|
tbh I'm hesitating, it can fall in both, since it only relies on the bars data. I'll need to think about it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed your fixing for bar_index: 2712222
Not sure if there are still some changes should be applied. Just for your consideration.
And 'bar_index' is a built-in variable or CONTEXT_DATA_VARS ? which is better?