Make out-of-place deinterleaving multi-threaded#100
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
=======================================
Coverage 99.79% 99.79%
=======================================
Files 8 8
Lines 1438 1438
=======================================
Hits 1435 1435
Misses 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…lize it as well" This reverts commit 6b48b49.
…g to an existing buffer to see how that performs
Collaborator
Author
|
So, interestingly, collecting the output of interleaving (combine_re_im) into a No difference on M4, that runs at 40GiB/s in both cases. That memory subsystem sure is something. |
Collaborator
Author
|
The x86 drop may be due to cache coherency protocols, where the data needs to be read before it can be overwritten. The intrinsics to bypass this are unstable in std but there are prefetch and prefetch_index crates that might help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3x improvement on both Zen4 and M4 for size 27. Part of #99
On par of #95 on x86 and far ahead of it on M4.
TODO: heuristics on when to switch over to multi-threading to avoid harming single-threaded performance.