Draft/extensible tx format (local version)#133
Draft
vivek-arte wants to merge 63 commits intoQED-it:mainfrom
Draft
Draft/extensible tx format (local version)#133vivek-arte wants to merge 63 commits intoQED-it:mainfrom
vivek-arte wants to merge 63 commits intoQED-it:mainfrom
Conversation
✅ Deploy Preview for zcash-zips-qedit ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Co-authored-by: Daira-Emma Hopwood <daira@jacaranda.org>
Co-authored-by: Daira-Emma Hopwood <daira@jacaranda.org>
nuttycom
force-pushed
the
draft/extensible_tx_format
branch
5 times, most recently
from
a0020fe to
986b087
Compare
nuttycom
force-pushed
the
draft/extensible_tx_format
branch
from
986b087 to
346b40d
Compare
…savings. In the aftermath of the recent coinholder vote, it became clear that the data-saving motivations for separating memos from transaction outputs had not been clearly represented in the draft ZIP. This alters the abstract and motivation sections to clarify this point.
Co-authored-by: Daira-Emma Hopwood <daira@jacaranda.org> Co-authored-by: Jack Grigg <thestr4d@gmail.com>
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
…-11.12.3 Update to katex 0.16.33 and mermaid 11.12.3
[zip-template] Adjust the title and regenerate README.rst
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
Pin multimarkdown to the zcash fork (commit 543434c9) instead of the nixpkgs package, ensuring the same version used by the Docker-based build. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace Docker-based GitHub Actions with composite actions that use cachix/install-nix-action and `nix develop` to run builds. This eliminates Docker flakiness in CI and uses the same reproducible Nix environment defined in flake.nix. Changes: - Convert render and render-protocol actions from Docker to composite - Remove safe.directory workarounds (only needed for Docker UID mismatch) - Use `make all` directly instead of `make all-docker` Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Use DeterminateSystems/magic-nix-cache-action to cache the Nix store across CI runs via GitHub Actions cache, avoiding repeated downloads of texlive and other large dependencies. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Use nix for rendering in CI
Co-authored-by: Jack Grigg <thestr4d@gmail.com> Co-authored-by: Kris Nuttycombe <kris@nutty.land>
[ZIP 231] Update abstract and motivation to clarify memo bundle data savings.
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
update ZIP-0234-block_subsidy.png
ZIP 32: clarify the entropy requirement for wallet seeds
nuttycom
force-pushed
the
draft/extensible_tx_format
branch
from
346b40d to
68f3ef9
Compare
…in rst2html5 The Nix flake was providing docutils' built-in rst2html5 (the html5_polyglot writer), but render.sh expects the separate PyPI package rst2html5 2.0.1 by André Felipe Dias, which has different math handling. This mismatch (introduced by the switch to Nix-based CI rendering) caused warnings for math commands like \underline and \mathbin, and for syntax highlighting of code blocks. This adds a custom derivation for rst2html5 2.0.1 from PyPI with its dependencies (docutils, Genshi, Pygments), matching the versions specified in zip-guide.rst. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: Daira-Emma Hopwood <daira@jacaranda.org>
ZIP metadata fixes
… and Orchard. Specifies the effecting and authorizing data structures for each bundle type, with value balance moved to mValuePoolDeltas as per the extensible tx format design. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…ment. Specifies the V6 transaction digest algorithms: - TxId digest with separate value_pool_deltas_digest and dynamic effects_bundles_digest - Signature digest for transparent input signing with hash_type support - Authorizing data commitment for witness data Key design decisions: - Value balances committed via top-level value_pool_deltas_digest (not per-bundle) - effects_bundles_digest uses tagged concatenation (bundle_type_id || root_hash) - Unknown bundle types supported by accepting their root hash externally Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…tion process. Restructure the specification to begin with a comprehensive introduction to protocol bundles, explaining effecting data, authorizing data, and the transparent transaction value pool concepts. Define the bundle type registration process that ZIPs must follow when introducing new bundle types. Move the bundle type registry to appear before the transaction format specification for better readability. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Update PR URL to 1156 and fix email addresses - Use conformance language (MAY/MUST NOT) for registry column descriptions - Add constraint that map keys must be in increasing order - Change "ordered by" to "in increasing order of" throughout - Fix "transparent transaction value pool" terminology - Change AssetUuid subscript notation to function notation - Add registry update mechanism language - Add "Defining ZIP" column to bundle type registry table - Rephrase consensus rules section to clarify modifications to protocol spec - Add clarifying text for fee bundle semantics (coinbase collects, others pay) - Add mutual exclusion consensus rule for Sapling/Orchard bundle variants Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Register bundle type 4 (Transaction fee) in the V6 bundle registry - Update consensus rules to use mValuePoolDeltas terminology - Replace header_digest modification with value_pool_deltas_digest reference - Add reference to extensible transaction format ZIP Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Register bundle type 5 (NSM field) in the V6 bundle registry - Update consensus rules to use mValuePoolDeltas terminology - Replace header_digest modification with value_pool_deltas_digest reference - Add reference to extensible transaction format ZIP Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Register Memos, Sapling-post-ZIP 231, and Orchard-post-ZIP 231 bundle types - Update encoding section to clarify it describes effecting data - Replace Transaction sighash section with Transaction Digest referencing ZIP XXX - Specify BLAKE2b-256 personalization strings for memo digest computation - Add reference to extensible transaction format ZIP - Fix zip-0230-note-plaintexts reference Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Register ZSA Issuance bundle type in the V6 bundle registry - Update digest section to reference effects_bundles_digest and auth_bundles_digest - Add reference to extensible transaction format ZIP - Remove unused ZIP 244 and ZIP 246 references Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Register OrchardZSA bundle type in the V6 bundle registry - Update digest section to reference effects_bundles_digest and auth_bundles_digest - Add reference to extensible transaction format ZIP - Remove unused ZIP 244 and ZIP 246 references Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…uples. This makes the mutual exclusivity of bundle variants (e.g. Orchard vs OrchardZSA) implicit in the map structure, and allows clients that do not recognize a specific bundleVersion to still identify which pool is affected. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add a section to ZIP 248 describing wallet requirements for handling unknown bundle types and versions. Update ZIP 226 to reference ZIP 248 instead of ZIP 230 for transaction format and wallet implications. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
nuttycom
force-pushed
the
draft/extensible_tx_format
branch
from
2397384 to
d345f8a
Compare
nuttycom
force-pushed
the
draft/extensible_tx_format
branch
from
d345f8a to
bd6f621
Compare
nuttycom
force-pushed
the
draft/extensible_tx_format
branch
from
bd6f621 to
e325e71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.