solved the issue with the pyre configuration and added a pyright conf…#487
Open
liliankavengi wants to merge 1 commit intoPython-Cardano:mainfrom
Open
solved the issue with the pyre configuration and added a pyright conf…#487liliankavengi wants to merge 1 commit intoPython-Cardano:mainfrom
liliankavengi wants to merge 1 commit intoPython-Cardano:mainfrom
Conversation
…iguration for better type checking. Also updated the txbuilder and certificate modules to improve functionality and added tests for the txbuilder.
cffls
reviewed
Mar 29, 2026
Collaborator
cffls
left a comment
cffls
left a comment
There was a problem hiding this comment.
Thanks for the PR! Currently, the project is using mypy for static type checking. Not sure if adding a new type checker is worth it. The feature for txbuilder seems useful though. Happy to include it if the checker and uv.lock is removed.
| @@ -0,0 +1,3 @@ | |||
| version = 1 | |||
Collaborator
There was a problem hiding this comment.
I will bring in uv support in a separate PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…iguration for better type checking. Also updated the txbuilder and certificate modules to improve functionality and added tests for the txbuilder.