Stop adding link-native-libraries flag by default in Emscripten platform in latest Rust#2991
Merged
Stop adding link-native-libraries flag by default in Emscripten platform in latest Rust#2991
Conversation
Contributor
|
The change to rust libc that fixed this problem occurred on Fri Nov 1 2024. But we can only build on stable since 1.93.0. Maybe gate this code behind a check on the date? Anything from 2025 or later doesn't need it. |
ryanking13
changed the title
Contributor
Author
|
Updated the condition to only work in < Rust 1.93.0 which might be the most conservative approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem with rust trying to link libc was fixed in rust-lang/libc#4002, and this flag is not needed anymore for recent rust versions.
Always adding this flag is preventing from using the stable Rust toolchain as
-Zflag can only be used with the nightly toolchains. From Rust 1.93.0, it is possible to use stable toolchain to build to Emscripten target, so this PR removes this flag for Rust >= 1.93.0cc: @hoodmane