chore: update action.yml to use full-length sha pinned action versions#29
Open
lhoupert wants to merge 1 commit intoPyCQA:mainfrom
Open
chore: update action.yml to use full-length sha pinned action versions#29lhoupert wants to merge 1 commit intoPyCQA:mainfrom
lhoupert wants to merge 1 commit intoPyCQA:mainfrom
Conversation
lhoupert
requested review from
ericwb,
lukehinds and
sigmavirus24
as code owners
Member
|
Seems pinning to shas is not as safe as we all thought: |
Author
|
Good point! There is this fork SHA resolution issue, but SHA pinning is still better than tags. Worth noting that GitHub just published their 2026 Actions security roadmap here: https://github.blog/news-insights/product-news/whats-coming-to-our-github-actions-2026-security-roadmap/ . It introduces a dependencies: lockfile section for workflows (similar to go.sum) to address exactly this class of problem. I think this PR is still a step in the right direction in the meantime :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #28