Conversation
Signed-off-by: NishantSinghhhhh <nishantsingh_230137@aitpune.edu.in>
Signed-off-by: NishantSinghhhhh <nishantsingh_230137@aitpune.edu.in>
Signed-off-by: NishantSinghhhhh <nishantsingh_230137@aitpune.edu.in>
Signed-off-by: NishantSinghhhhh <nishantsingh_230137@aitpune.edu.in>
Signed-off-by: NishantSinghhhhh <nishantsingh_230137@aitpune.edu.in>
Signed-off-by: NishantSinghhhhh <nishantsingh_230137@aitpune.edu.in>
Signed-off-by: NishantSinghhhhh <nishantsingh_230137@aitpune.edu.in>
|
🎉 Thanks for opening this pull request, @NishantSinghhhhh! • Linked issue: no linked issue |
Signed-off-by: NishantSinghhhhh <nishantsingh_230137@aitpune.edu.in>
|
🎉 Thanks for opening this pull request, @NishantSinghhhhh! • Linked issue: no linked issue |
| @@ -1,196 +1 @@ | |||
| import express, { Application, Request, Response, NextFunction } from "express"; | |||
There was a problem hiding this comment.
Remove old console.log statement if it's no longer needed.
src/index.ts
Outdated
| // ✅ Serverless export (required for Vercel) | ||
| export default app; | ||
|
|
||
| erververver No newline at end of file |
There was a problem hiding this comment.
Ensure the new console.log statement is necessary for debugging.
Signed-off-by: NishantSinghhhhh <nishantsingh_230137@aitpune.edu.in>
src/auth/github.ts
Outdated
| @@ -8,9 +8,6 @@ import dotenv from "dotenv"; | |||
|
|
|||
| dotenv.config(); | |||
There was a problem hiding this comment.
Consider keeping the serializeUser function for future use or documentation.
src/auth/github.ts
Outdated
| @@ -25,15 +22,16 @@ passport.use( | |||
| scope: [ | |||
There was a problem hiding this comment.
Ensure that the new scopes added are necessary for your application's functionality.
| @@ -32,7 +32,6 @@ app.use(cors({ | |||
|
|
|||
There was a problem hiding this comment.
Remove commented-out code to maintain clean code practices.
Signed-off-by: NishantSinghhhhh <nishantsingh_230137@aitpune.edu.in>
|
🎉 Thanks for opening this pull request, @NishantSinghhhhh! • Linked issue: no linked issue |
Signed-off-by: NishantSinghhhhh <nishantsingh_230137@aitpune.edu.in>
|
🎉 Thanks for opening this pull request, @NishantSinghhhhh! • Linked issue: no linked issue |
Signed-off-by: NishantSinghhhhh <nishantsingh_230137@aitpune.edu.in>
Signed-off-by: NishantSinghhhhh <nishantsingh_230137@aitpune.edu.in>
|
🎉 Thanks for opening this pull request, @NishantSinghhhhh! • Linked issue: no linked issue |
|
🎉 Thanks for opening this pull request, @NishantSinghhhhh! • Linked issue: no linked issue |
|
🎉 Thanks for opening this pull request, @NishantSinghhhhh! • Linked issue: no linked issue |
src/auth/github.ts
Outdated
| @@ -8,9 +8,6 @@ import dotenv from "dotenv"; | |||
|
|
|||
| dotenv.config(); | |||
There was a problem hiding this comment.
Consider keeping the serializeUser function for future use or documentation.
src/auth/github.ts
Outdated
| done(null, user); | ||
| }); | ||
|
|
||
| passport.deserializeUser((obj: any, done) => { |
There was a problem hiding this comment.
Ensure that the new scopes added are necessary for your application's functionality.
| @@ -32,7 +32,6 @@ app.use(cors({ | |||
|
|
|||
There was a problem hiding this comment.
Remove commented code if it's no longer needed to keep the codebase clean.
| import { VerifyCallback } from "passport-oauth2"; | ||
| import dotenv from "dotenv"; | ||
|
|
||
| dotenv.config(); |
There was a problem hiding this comment.
Consider keeping the serializeUser function for future use or documentation.
src/auth/github.ts
Outdated
| userToken:string|null, // ← can be null but code never checks | ||
| githubUser: any, // ← “any” everywhere | ||
| db: any, // mongo? sql? nobody knows | ||
| logger?: { info(...args:any[]):void } // optional logger never called |
There was a problem hiding this comment.
Ensure that the new scopes added are necessary for your application's functionality.
| @@ -32,7 +32,6 @@ app.use(cors({ | |||
|
|
|||
There was a problem hiding this comment.
Remove commented-out code to maintain clean code practices.
|
🎉 Thanks for opening this pull request, @NishantSinghhhhh! • Linked issue: no linked issue |
|
🎉 Thanks for opening this pull request, @NishantSinghhhhh! • Linked issue: no linked issue |
|
@pullquestai form |
No description provided.