[perf] Stagger stack-hack scans to smooth second-update load

[Xekep]

Summary

• add per-player stack-scan timestamp state
• schedule stack checks at 5s intervals instead of every second per player
• initialize timestamps with player-index offset to spread work

Scope

• focused changes in TSPlayer and TShock.OnSecondUpdate`n- no unrelated file changes

[hakusaro]

@greptile review

[greptile-apps]

Greptile Summary

Implements performance optimization by throttling stack-hack detection from every second to 5-second intervals per player, with staggered initialization to distribute load.

Key Changes:

• Added LastStackDetectionCheck timestamp field to track per-player scan timing
• Initialized timestamp with -(index % 5) offset to stagger checks across players
• Wrapped stack detection in 5-second interval check before running expensive HasHackedItemStacks()

Critical Issue:

• player.IsBeingDisabled() and player.Disable() were moved outside the ServerSideCharacter conditional (line 1235-1238), changing behavior from original code where this only ran when !Main.ServerSideCharacter || (Main.ServerSideCharacter && player.IsLoggedIn)

Confidence Score: 2/5

• Logic bug breaks ServerSideCharacter behavior - requires fix before merge
• The performance optimization logic is sound, but moving player.Disable() outside the ServerSideCharacter check is a critical behavior change that affects when players get disabled
• TShockAPI/TShock.cs requires immediate attention - the IsBeingDisabled() block must be moved back inside the ServerSideCharacter conditional

Important Files Changed

Filename	Overview
TShockAPI/TSPlayer.cs	Added LastStackDetectionCheck field and staggered initialization using index % 5 to distribute stack-scan load
TShockAPI/TShock.cs	Throttled stack detection to 5s intervals but moved player.Disable() outside ServerSideCharacter check, changing behavior

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[OnSecondUpdate fires every second] --> B{ServerSideCharacter check}
    B -->|Pass: !SSC OR SSC && IsLoggedIn| C{Check: 5s elapsed since LastStackDetectionCheck?}
    B -->|Fail| E
    C -->|Yes: stackCheckDue = true| D[Update LastStackDetectionCheck = Now]
    C -->|No: < 5s elapsed| E
    D --> F{Has ignorestackhackdetection permission?}
    F -->|No| G[Run HasHackedItemStacks]
    F -->|Yes: skip check| E
    G --> H[Set IsDisabledForStackDetection]
    H --> E{IsBeingDisabled?}
    E -->|Yes| I[Call player.Disable]
    E -->|No| J[End]
    I --> J
    
    style C fill:#90EE90
    style E fill:#FFB6C6
    style I fill:#FFB6C6

Loading

_{Last reviewed commit: a6c6918}

[greptile-apps]

_{2 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

player.Disable() now runs outside the ServerSideCharacter check, changing original behavior. Previously only disabled when !Main.ServerSideCharacter || (Main.ServerSideCharacter && player.IsLoggedIn), now runs unconditionally.

Move this block inside the closing brace at line 1233:

Suggested change

	if (player.IsBeingDisabled())
	{
	player.Disable(flags: flags);
	}
	}
	if (player.IsBeingDisabled())
	{
	player.Disable(flags: flags);
	}
	}