Skip to content

Replace documents page with Resumier microfrontend embed#244

Open
adriandarian wants to merge 1 commit intomainfrom
codex/create-proposal-for-microfrontend-integration
Open

Replace documents page with Resumier microfrontend embed#244
adriandarian wants to merge 1 commit intomainfrom
codex/create-proposal-for-microfrontend-integration

Conversation

@adriandarian
Copy link
Member

Motivation

  • Replace the large, standalone Documents page implementation with an embeddable Resumier microfrontend to simplify demos and enable a shared Prosperis app experience.
  • Allow the Resumier app to run standalone for development while being embedded in THRIVE for production demos via a configurable URL.
  • Keep the integration lightweight and non-invasive so THRIVE's existing document stores and migrations are not changed in this PR.

Description

  • The /documents route now renders a new ResumierMicrofrontend component instead of the original Documents page logic by replacing src/routes/documents.tsx to return <ResumierMicrofrontend />.
  • Added src/components/features/documents/ResumierMicrofrontend.tsx which loads the microfrontend from the VITE_RESUMIER_URL env var and shows a helpful fallback message when the URL is not set.
  • Added the integration proposal document at docs/proposals/resumier-microfrontend.md that describes the embed approach, rollout plan, and open questions.
  • The change removes the previous Documents page implementation (large deletions) and leaves a single iframe-based integration point to be iterated on later.

Testing

  • No automated tests were run for this change (none requested during the rollout).

Codex Task

@vercel
Copy link

vercel bot commented Dec 27, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
thrive Error Error Dec 27, 2025 4:11am

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +20 to +23
<iframe
title="Resumier microfrontend"
src={resumierUrl}
className="h-full min-h-[80vh] w-full border-0"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Forward document selection into embed URL

The iframe src is always just VITE_RESUMIER_URL, so any document-selection context in the parent URL is dropped. Other parts of the app still navigate to /documents with a docId query (e.g., LinkedDocumentsPopover uses navigate({ to: '/documents', search: { docId } })), which previously opened a specific document. With the new embed, that docId never reaches Resumier, so clicking “View document” from an application will no longer open the intended document. Consider appending window.location.search (or a docId param) to the iframe src, or using postMessage, so the microfrontend can preserve this deep-link behavior.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant