Replace documents page with Resumier microfrontend embed#244
Replace documents page with Resumier microfrontend embed#244adriandarian wants to merge 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <iframe | ||
| title="Resumier microfrontend" | ||
| src={resumierUrl} | ||
| className="h-full min-h-[80vh] w-full border-0" |
There was a problem hiding this comment.
Forward document selection into embed URL
The iframe src is always just VITE_RESUMIER_URL, so any document-selection context in the parent URL is dropped. Other parts of the app still navigate to /documents with a docId query (e.g., LinkedDocumentsPopover uses navigate({ to: '/documents', search: { docId } })), which previously opened a specific document. With the new embed, that docId never reaches Resumier, so clicking “View document” from an application will no longer open the intended document. Consider appending window.location.search (or a docId param) to the iframe src, or using postMessage, so the microfrontend can preserve this deep-link behavior.
Useful? React with 👍 / 👎.
Motivation
Description
/documentsroute now renders a newResumierMicrofrontendcomponent instead of the original Documents page logic by replacingsrc/routes/documents.tsxto return<ResumierMicrofrontend />.src/components/features/documents/ResumierMicrofrontend.tsxwhich loads the microfrontend from theVITE_RESUMIER_URLenv var and shows a helpful fallback message when the URL is not set.docs/proposals/resumier-microfrontend.mdthat describes the embed approach, rollout plan, and open questions.Testing
Codex Task