Conversation
Co-authored-by: gfauredev <19304085+gfauredev@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix macOS aarch64-darwin Nix build
Fix macOS (aarch64-darwin) build: replace zoned_time with portable localtime_r/strftime
Mar 14, 2026
📊 Coverage ReportCoverage Summary |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::chrono::zoned_timeandstd::chrono::current_zone()are absent from Apple's libc++ on macOS 14, breaking every translation unit that includesLogger.hpp.Changes
include/Logger.hpp: Replacezoned_time-basedtime()anddate()helpers withlocaltime_r+strftime. Add<ctime>include. Update doc comment (format is nowHH:MM:SS, notHH:MM:SS.mmm).test/LoggerTest.cpp: Same substitution in the log-rotation test case that reproduced the date string independently.Before
After
localtime_ris POSIX-standard and thread-safe, covering both Linux and macOS.📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.