Merged
Conversation
jmcarp
force-pushed
the
test-coverage
branch
2 times, most recently
from
2039bf4 to
59e53cc
Compare
Contributor
|
i have no preference @jmcarp - how about you @schuyler1d , @hiemanshu ? |
Collaborator
|
I don't have a preference. My main request is we use one that isn't overly 'chatty'. e.g. coveralls.io seems to message 4 times per PR (or did/sometimes does): hdachev/fakeredis#60 |
Contributor
Author
|
Updated to push coverage reports to code climate: https://codeclimate.com/github/jmcarp/Spoke. To get this working on upstream, we'll need to sign up for code climate (free for open source), add this repo, and use |
Contributor
Author
|
This is ready for review, so I'm dropping the |
shakalee14
approved these changes
Nov 22, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TBD: upload coverage reports to a service like code climate or codecov and warn on patches that decrease coverage. Any preferences on a code coverage service @schuyler1d @shakalee14 ?