Fix File Access Control & UI Issues in File Messages#72
Merged
Conversation
…ccess, and file paste) #61 - Disable Share Extension activation so the app does not appear in the iOS Share Sheet - Disable external document access via Files app (UIFileSharingEnabled=false, LSSupportsOpeningDocumentsInPlace=false) - Block image/file paste from clipboard in chat input - Allow text paste to continue working normally Tests: - Verify app does not appear in iOS Share Sheet - Verify Files app cannot open files in the app - Verify image/file paste from clipboard is blocked - Verify text paste continues to work This ensures files cannot be imported into the app from outside sources.
… and light theme UI #63 - Show owner information in Peer1 without status or permission icons - Display shared user information in Peer2 with download/forward permissions - Add access status messages (Access Until, File Expired, Access Revoked, Access Denied) - Add forwarded users section - Implement search functionality for forwarded users - Show search bar only when forwarded users count is greater than 10 - Hide owner and shared sections during search - Show "No Forwarded User found with <name>" when search has no results - Append "(You)" label for owner (Peer1) and shared user (Peer2) - Truncate long usernames while preserving "(You)" label - Fix light theme visibility issues (back icon, search text, hint text, close icon) Test: - Verified owner information displays correctly in Peer1 without status icons - Verified shared users show correct permissions and access status in Peer2 - Confirmed forwarded users appear in a separate section - Verified search bar appears only when forwarded users count is greater than 10 - Tested forwarded user search functionality and empty state message - Verified "(You)" label displays correctly even with long usernames - Checked UI visibility in both Light and Dark themes
test: verified logs are visible only in Debug build and not in Release build issur ref #65
- Disabled forward option in UI for revoked/denied/expired access
- Added backend validation to block forwarding without valid access
- Returned proper error response for invalid forward attempts
- Added unit and integration tests for access state scenarios
Tests Done:
- Verified user cannot forward file when access is revoked
- Verified user cannot forward file when access is denied
- Verified user cannot forward file when access is expired
- Verified authorized users can still forward files
- Verified API rejects direct forward requests without valid access
- Verified proper error message is returned ("File access is no longer valid")
Issur Ref #69
- Removed bell icon from group file message layout - Set visibility to gone for unused notification icon - Ensured no UI break or spacing issues after removal Tests Done: - Verified bell icon is not visible in group file messages - Verified file message layout remains properly aligned - Verified no spacing or UI break after removal - Verified other message types are unaffected - Verified behavior across different screen sizes/devices - Performed regression testing for file send/receive functionality Git Issue Ref #70
- Removed access status labels (Until / Expired / Revoked / Denied) from group file messages - Improved UI clarity by hiding unnecessary access information - Ensured layout remains consistent after removal Tests Done: - Verified access status is not visible in iPhone group chat file messages - Verified UI layout and spacing remain intact - Verified one-to-one chat behavior is unaffected - Verified across different iPhone screen sizes - Performed regression testing for file message functionality Issue Ref #71
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📄 Summary
This MR addresses multiple issues related to file access control and UI inconsistencies in file messages across platforms.
🐛 Issues Fixed
🔧 Changes Implemented
🔒 Access Control Fix
Blocked file forwarding when user access is:
Added backend validation to prevent API-level bypass
Added proper error response:
"File access is no longer valid"🎨 UI Improvements
Removed notification bell icon from group file messages
Hid file access status labels in iPhone group chat:
Ensured UI consistency and no layout break after changes
✅ Testing Done
🔒 Access Control
🎨 UI Validation
📱 Cross-Checks