Access Control Page Improvements (Peer1 & Peer2)#64
Merged
Conversation
…ccess, and file paste) #61 - Disable Share Extension activation so the app does not appear in the iOS Share Sheet - Disable external document access via Files app (UIFileSharingEnabled=false, LSSupportsOpeningDocumentsInPlace=false) - Block image/file paste from clipboard in chat input - Allow text paste to continue working normally Tests: - Verify app does not appear in iOS Share Sheet - Verify Files app cannot open files in the app - Verify image/file paste from clipboard is blocked - Verify text paste continues to work This ensures files cannot be imported into the app from outside sources.
… and light theme UI #63 - Show owner information in Peer1 without status or permission icons - Display shared user information in Peer2 with download/forward permissions - Add access status messages (Access Until, File Expired, Access Revoked, Access Denied) - Add forwarded users section - Implement search functionality for forwarded users - Show search bar only when forwarded users count is greater than 10 - Hide owner and shared sections during search - Show "No Forwarded User found with <name>" when search has no results - Append "(You)" label for owner (Peer1) and shared user (Peer2) - Truncate long usernames while preserving "(You)" label - Fix light theme visibility issues (back icon, search text, hint text, close icon) Test: - Verified owner information displays correctly in Peer1 without status icons - Verified shared users show correct permissions and access status in Peer2 - Confirmed forwarded users appear in a separate section - Verified search bar appears only when forwarded users count is greater than 10 - Tested forwarded user search functionality and empty state message - Verified "(You)" label displays correctly even with long usernames - Checked UI visibility in both Light and Dark themes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merge request improves the Access Control page UI and functionality for both Peer1 (Owner) and Peer2 screens to enhance visibility of file ownership, permissions, and forwarded user management.
Changes
Display Owner information in Peer1 without status indicators or permission icons
Show Shared user information in Peer2 with:
Download permission icon
Forward permission icon
File access statuses:
Access Until $dateFile Expired On $dateAccess RevokedAccess DeniedAdd a Forwarded Users section
Implement search functionality for forwarded users
Display search icon only when forwarded user count is greater than 10
Hide Owner and Shared sections during search
Show empty state message:
No Forwarded User found with <searched_name>Append "(You)" label:
Truncate long usernames while ensuring "(You)" remains visible
Fix Light Theme UI visibility issues:
Testing
Closes #63