Fix PSAvoidUsingConvertToSecureStringWithPlainText in tests#115
Open
jshigetomi wants to merge 10 commits intoPowerShell:mainfrom
Open
Fix PSAvoidUsingConvertToSecureStringWithPlainText in tests#115jshigetomi wants to merge 10 commits intoPowerShell:mainfrom
jshigetomi wants to merge 10 commits intoPowerShell:mainfrom
Conversation
Blank commit to fix OneBranch through PR validation
…ll module versions (PowerShell#112) Use `RequiredResource` hashtable to specify PowerShell module versions (PowerShell#112)
Bumps [dotnet-sdk](https://github.com/dotnet/sdk) from 8.0.300 to 8.0.318. - [Release notes](https://github.com/dotnet/sdk/releases) - [Commits](dotnet/sdk@v8.0.300...v8.0.318)
…8-68676 into main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This pull request updates test code for the
Microsoft.PowerShell.SecretStoremodule to improve howSecureStringobjects are created, and also updates the .NET SDK version inglobal.json. Additionally, a new metadata file is added for inventory and ownership tracking. The most important changes are summarized below:Test improvements and code consistency:
ConvertTo-SecureString -AsPlainText -Forcewith[System.Net.NetworkCredential]::new('', $string).SecurePasswordfor creatingSecureStringobjects inMicrosoft.PowerShell.SecretStore.Tests.ps1, ensuring more robust and consistent test code. [1] [2] [3] [4]Build and environment updates:
global.jsonfrom8.0.300to8.0.318to use a newer SDK for builds.Metadata and ownership tracking:
es-metadata.ymlfile specifying schema version, provider information, production status, accountable owners, and default routing for the service.PR Context
This PR is to fix an SFI bug on the ADO side. Changes merged here are all changes from ADO main branch that need to be on GitHub before mirroring can begin.