Fix incorrect method name in get_events#214
Closed
04cb wants to merge 1 commit intoPolymarket:mainfrom
Closed
Conversation
The get_events method was calling parse_event which does not exist. Changed to parse_pydantic_event to match the actual method name in the class.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #35. The get_events method was calling parse_event which does not exist. Changed to parse_pydantic_event to match the actual method name defined in the GammaMarketClient class.
Note
Low Risk
Single-line fix to call the correct event parser; low risk aside from potentially changing returned event object shape when
parse_pydantic=True.Overview
Fixes a broken code path in
GammaMarketClient.get_eventswhere the pydantic parsing branch called a non-existentparse_eventmethod.When
parse_pydantic=True, events are now parsed viaparse_pydantic_event, preventing runtime errors and returningPolymarketEventinstances as intended.Written by Cursor Bugbot for commit b18afc7. This will update automatically on new commits. Configure here.