add i2c commands#11
add i2c commands#11jabdoa2 wants to merge 3 commits intoPierreRust:masterfrom jabdoa2:add_i2c_commands
Conversation
|
Thanks for your contribution ! |
|
It can wait a bit. The feature is not upstream yet in MPF so our users are not using it yet. I tested it with a RPi3 and a MMA8451. |
|
I'm wanting to use an i2c LCD display (using the pigpio I2C LCD class) asynchronously. I think that everything is covered in this PR, except the i2c_write_device method. I'm still getting to grips with async in Python so have broadly adapted the pigpio module's code, following your refactoring process to get the following code: If this is correct, please can you add it to this PR? Thanks! |
|
@orbsmiv: just create a PR based on my PR. Please also test it. |
|
@jabdoa2 sure, although I've not done a stacked PR before... is the process to fork your repo and then submit a PR on your add_i2c_commands branch? |
|
Fork mine and then create a PR against this repo. That will also contain the changes of my PR which then would have to be merged first |
|
@PierreRust any chance we can merge this? |
Add some i2c commands:
Fix locking and asyncio sendall calls