Skip to content

F/logger cm read method#10

Open
alexander3771 wants to merge 7 commits intoPierreRust:masterfrom
alexander3771:f/logger_cm_read_method
Open

F/logger cm read method#10
alexander3771 wants to merge 7 commits intoPierreRust:masterfrom
alexander3771:f/logger_cm_read_method

Conversation

@alexander3771
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown
Owner

@PierreRust PierreRust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand why you want to remove this method, could you explain it ?

Copy link
Copy Markdown
Owner

@PierreRust PierreRust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks, I'll accept it with the remaining of the PR.

@alexander3771
Copy link
Copy Markdown
Author

How do you look at dropping support python3.4 and write everywhere async/await?

Alexander Myskin added 2 commits November 8, 2017 21:35
@PierreRust
Copy link
Copy Markdown
Owner

I've just checked, python 3.5 is the default python3 on Raspbian Stretch so, yes, I'm definitely in favor of dropping 3.4 constructs (which where clumsy anyway) !

@jabdoa2
Copy link
Copy Markdown
Contributor

jabdoa2 commented Jan 14, 2018

Please don't drop 3.4 yet. This is still actively used by almost all our users. It will take a while until everybody migrates to Ubuntu 18.04 LTS (September earliest). Also some of our Windows folks still cannot use 3.5 because of problems with Kivy. Is there anything we would gain from this except a slightly nicer syntax?

@jabdoa2
Copy link
Copy Markdown
Contributor

jabdoa2 commented Jun 10, 2018

We gathered some data on this: https://groups.google.com/forum/m/#!topic/mpf-users/omWVIaroykQ

Copy link
Copy Markdown
Author

@alexander3771 alexander3771 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrapped python3.5 code into if statement for backward compatibility
Review pls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants