Conversation
PierreRust
left a comment
There was a problem hiding this comment.
I'm not sure I understand why you want to remove this method, could you explain it ?
PierreRust
left a comment
There was a problem hiding this comment.
Looks good, thanks, I'll accept it with the remaining of the PR.
|
How do you look at dropping support python3.4 and write everywhere async/await? |
# Conflicts: # apigpio/apigpio.py
|
I've just checked, python 3.5 is the default python3 on Raspbian Stretch so, yes, I'm definitely in favor of dropping 3.4 constructs (which where clumsy anyway) ! |
|
Please don't drop 3.4 yet. This is still actively used by almost all our users. It will take a while until everybody migrates to Ubuntu 18.04 LTS (September earliest). Also some of our Windows folks still cannot use 3.5 because of problems with Kivy. Is there anything we would gain from this except a slightly nicer syntax? |
|
We gathered some data on this: https://groups.google.com/forum/m/#!topic/mpf-users/omWVIaroykQ |
alexander3771
left a comment
There was a problem hiding this comment.
Wrapped python3.5 code into if statement for backward compatibility
Review pls
No description provided.