Conversation
|
Solves #3 |
|
Would you mind updating the GitHub test workflow to run on ubuntu, macos and windows? I can't verify this right now, so just want to make sure it'll still compile elsewhere |
|
Sure, although it might take a while, as I’m a bit busy right now.
|
| Jargon's Windows compilation relies on MSYS2. It has been tested on the MINGW64 environment. | ||
|
|
||
| First, install dependencies with `pacman` | ||
| First, install dependencies with your package manager. For example, with `pacman`: |
There was a problem hiding this comment.
MSYS2's package manager is pacman, I don't see how someone would use something else
|
Modified workflow to test on MacOS and Windows. Everything should be done now! |
.github/workflows/test.yml
Outdated
| run: make compile | ||
| - name: Run tests | ||
| run: make test | ||
| test-macos-intel: |
There was a problem hiding this comment.
This should be done by adding another matrix rather than creating separate jobs for each. Please see GitHub Actions docs
There was a problem hiding this comment.
Oh, I didn't know that. There will need to have a separate job to test on Windows, as there is additional setup needed. Is that fine?
There was a problem hiding this comment.
It should be fixed now!
|
Your tests are failing still. Also, would you mind adding matrix.os to the test title? |
|
I don't know why they are failing, it just says "job failed" and has no logs. I don't see why it should fail. I'll add the matrix.os in the title and I'll see whether it shows some logs when rerun |
2 participants
This PR adds support for compiling on Windows through MSYS2.
Changes made:
Makefilesargon2, as only the source files are used to compilejargon.so/jargon.dll, changing based on OS