Skip to content

fix version-packages for src/changelog#316

Merged
maxnorm merged 1 commit intoPerfect-Abstractions:mainfrom
maxnorm:feat/add-pkg
Mar 30, 2026
Merged

fix version-packages for src/changelog#316
maxnorm merged 1 commit intoPerfect-Abstractions:mainfrom
maxnorm:feat/add-pkg

Conversation

@maxnorm
Copy link
Copy Markdown
Collaborator

@maxnorm maxnorm commented Mar 30, 2026

Summary

Changes Made

Checklist

Before submitting this PR, please ensure:

  • Code follows the Solidity feature ban - No inheritance, constructors, modifiers, public/private variables, external library functions, using for directives, or selfdestruct

  • Code follows Design Principles - Readable, uses diamond storage, favors composition over inheritance

  • Code matches the codebase style - Consistent formatting, documentation, and patterns (e.g. ERC20Facet.sol)

  • Code is formatted with forge fmt

  • Existing tests pass - Run tests to be sure existing tests pass.

  • New tests are optional - If you don't provide tests for new functionality or changes then please create a new issue so this can be assigned to someone.

  • All tests pass - Run forge test and ensure everything works

  • Documentation updated - If applicable, update relevant documentation

  • Changesets — If this PR changes publishable packages (src/, cli/), changeset-bot will comment if a release note might be needed. You can add one when convenient or defer to maintainers.

Make sure to follow the contributing guidelines.

Additional Notes

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 30, 2026

⚠️ No Changeset found

Latest commit: c8306d8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 30, 2026

👷 Deploy request for compose-diamonds pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit c8306d8

@maxnorm maxnorm merged commit a3833f6 into Perfect-Abstractions:main Mar 30, 2026
5 checks passed
@github-actions
Copy link
Copy Markdown

Coverage Report

Coverage

Metric Coverage Details
Lines 79% 1560/1981 lines
Functions 92% 445/483 functions
Branches 74% 161/217 branches

Last updated: Mon, 30 Mar 2026 01:22:51 GMT for commit c8306d8

@github-actions
Copy link
Copy Markdown

Gas Report

No gas usage changes detected between main and feat/add-pkg.

All functions maintain the same gas costs. ✅

Last updated: Mon, 30 Mar 2026 01:23:23 GMT for commit c8306d8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant