Skip to content

Add pkg#312

Closed
maxnorm wants to merge 154 commits intoPerfect-Abstractions:mainfrom
maxnorm:add-pkg
Closed

Add pkg#312
maxnorm wants to merge 154 commits intoPerfect-Abstractions:mainfrom
maxnorm:add-pkg

Conversation

@maxnorm
Copy link
Copy Markdown
Collaborator

@maxnorm maxnorm commented Mar 26, 2026

Summary

Changes Made

Checklist

Before submitting this PR, please ensure:

  • Code follows the Solidity feature ban - No inheritance, constructors, modifiers, public/private variables, external library functions, using for directives, or selfdestruct

  • Code follows Design Principles - Readable, uses diamond storage, favors composition over inheritance

  • Code matches the codebase style - Consistent formatting, documentation, and patterns (e.g. ERC20Facet.sol)

  • Code is formatted with forge fmt

  • Existing tests pass - Run tests to be sure existing tests pass.

  • New tests are optional - If you don't provide tests for new functionality or changes then please create a new issue so this can be assigned to someone.

  • All tests pass - Run forge test and ensure everything works

  • Documentation updated - If applicable, update relevant documentation

Make sure to follow the contributing guidelines.

Additional Notes

maxnorm and others added 26 commits March 12, 2026 19:51
add readme for doc gen, action only on trigger
@netlify
Copy link
Copy Markdown

netlify bot commented Mar 26, 2026

👷 Deploy request for compose-diamonds pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 7bfaf09

@github-actions
Copy link
Copy Markdown

Coverage Report

Coverage

Metric Coverage Details
Lines 79% 1560/1981 lines
Functions 92% 445/483 functions
Branches 74% 161/217 branches

Last updated: Thu, 26 Mar 2026 16:50:58 GMT for commit 7bfaf09

@github-actions
Copy link
Copy Markdown

Gas Report

No gas usage changes detected between main and add-pkg.

All functions maintain the same gas costs. ✅

Last updated: Thu, 26 Mar 2026 16:51:31 GMT for commit 7bfaf09

@maxnorm maxnorm closed this Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant