Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the connection-based routing documentation to reflect the current signal-type handling behavior, and tightens tie line creation to prevent building tie lines when port signal types are incompatible.
Changes:
- Updated tie line
typedocumentation to describe intersection-based signal type calculation and override behavior. - Changed
TieLine.Typeto use the intersection of source/destination port signal types (unless overridden). - Added signal type compatibility validation during
TieLineConfig.GetTieLine()creation.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/PepperDash.Essentials.Core/Routing/TieLineConfig.cs | Adds signal-type compatibility validation before creating tie lines; updates OverrideType docstring. |
| src/PepperDash.Essentials.Core/Routing/TieLine.cs | Changes tie line effective signal type to source/destination intersection; updates XML docs accordingly. |
| docs/docs/technical-docs/Connection-Based-Routing.md | Expands routing docs to describe signal splitting/filtering and tie line type determination/validation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
ndorin
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to the connection-based routing system, focusing on how tie lines and signal types are handled, validated, and documented. The changes enhance both the routing algorithm and configuration validation, making routing more robust and flexible. The documentation is also updated to clearly explain these new behaviors and best practices.
Routing algorithm and signal type handling:
audioVideoare automatically split into separate routing operations for each signal. The routing algorithm only considers tie lines compatible with the requested signal type, ensuring correct and flexible path discovery. [1] [2] [3]Tie line configuration and validation:
typeoverride is specified in configuration. This ensures only compatible signals are routed. [1] [2] [3] [4] [5]Documentation updates:
These changes collectively make the routing system more reliable, easier to configure correctly, and better documented for future users and maintainers.