Skip to content

feat(custom-issuer-go): add health check and Prometheus metrics#91

Draft
kpitapeersyst wants to merge 1 commit intomainfrom
feat/custom-issuer-go-health-metrics
Draft

feat(custom-issuer-go): add health check and Prometheus metrics#91
kpitapeersyst wants to merge 1 commit intomainfrom
feat/custom-issuer-go-health-metrics

Conversation

@kpitapeersyst
Copy link
Copy Markdown
Contributor

feat(custom-issuer-go): add health endpoints and Prometheus metrics

Changes 🛠️

apps/custom-issuer-go

  • Added health endpoints:
    • /livez -> liveness probe, always returns 200 OK
    • /readyz -> readiness probe, checks validation keys are loaded and KMS signing capability, returns 200 OK or 503 Service Unavailable
  • Added Prometheus metrics integration
    • Exposed /metrics endpoint serving all Prometheus-formatted metrics for scraping
    • custom_issuer_go_tokens_issued_total (counter) -> total successfully issued tokens
    • custom_issuer_go_tokens_failed_total (counter) -> total failed token issuance attempts
    • custom_issuer_go_issue_duration_seconds (histogram) -> token issuance duration
  • Added HasValidationKeys() method to IssuerService
  • Added Ping(ctx) method to KMSService for health-check signing probe

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fast-auth-spa Ready Ready Preview, Comment Mar 20, 2026 4:16pm

Request Review

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 20, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b82260b3-baee-48d4-a87a-fcb2e055a812

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/custom-issuer-go-health-metrics

Comment @coderabbitai help to get the list of available commands and usage tips.

@socket-security
Copy link
Copy Markdown

@socket-security
Copy link
Copy Markdown

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
Obfuscated code: npm entities is 91.0% likely obfuscated

Confidence: 0.91

Location: Package overview

From: pnpm-lock.yamlnpm/entities@4.5.0

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/entities@4.5.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
Obfuscated code: npm entities is 91.0% likely obfuscated

Confidence: 0.91

Location: Package overview

From: pnpm-lock.yamlnpm/entities@6.0.1

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/entities@6.0.1. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant