Skip to content

Refactor/updates#11

Open
AndronikosKostas wants to merge 17 commits intomainfrom
refactor/updates
Open

Refactor/updates#11
AndronikosKostas wants to merge 17 commits intomainfrom
refactor/updates

Conversation

@AndronikosKostas
Copy link
Copy Markdown
Member

No description provided.

@AndronikosKostas AndronikosKostas requested a review from ktsoupos May 24, 2025 17:54
@AndronikosKostas
Copy link
Copy Markdown
Member Author

@ktsoupos...Γενικά show trust except timebased scheduling διότι εκει ζορίστηκα λίγο στην insertActivities οποτε θελει ενα στρωσιμο (την έβαλα σχόλια) και check the errors in the ST[01] because I am not sure 100% how you want them...Επίσης Ι am not sure about UTCTimestamp readUTCTimestamp() so check it out...
All the other stuff is more trustworthy (all the parse functions, storeMessage, the Message class). Προτεινω να μπεις και να κάνεις τις αλλαγές στα παραπάνω οπου χρειαζεται για να μη χάνουμε χρόνο.

@ktsoupos
Copy link
Copy Markdown
Contributor

ktsoupos commented May 25, 2025

@AndronikosKostas i'd suggest that we keep etl::expected for consistency in error handling and check with .has_value.
Is there any reason to pass the errors (like "error" or "Message too large") to the actual message ?

@AndronikosKostas
Copy link
Copy Markdown
Member Author

@AndronikosKostas i'd suggest that we keep etl::expected for consistency in error handling and check with .has_value. Is there any reason to pass the actual errors (like "error" or "Message too large") to the actual message ?

Δεν θυμαμαι αν τα ειχα πειραξει εγω αυτα...καντα οπως τα θες δεν εχω θεμα

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants