Skip to content

Feat: add cmake config, fix issue with filesize on linux, apply commits from upstream, other improvements#4

Open
Bizzonium wants to merge 10 commits intoParadiseSS13:masterfrom
ss220-space:feat/improvements
Open

Feat: add cmake config, fix issue with filesize on linux, apply commits from upstream, other improvements#4
Bizzonium wants to merge 10 commits intoParadiseSS13:masterfrom
ss220-space:feat/improvements

Conversation

@Bizzonium
Copy link
Copy Markdown

No description provided.

@Bizzonium Bizzonium marked this pull request as ready for review February 17, 2024 18:58
@Bizzonium Bizzonium force-pushed the feat/improvements branch from 44ab287 to 97924fd Compare July 13, 2024 16:54
@Bizzonium
Copy link
Copy Markdown
Author

not tested yet in production, please wait

@AffectedArc07
Copy link
Copy Markdown
Member

Tried building windows on this branch

c:\Users\AffectedArc07\Documents\GitHub\Parastuff\ParaByondTracy>cl.exe /nologo /std:c11 /O2 /LD /DNDEBUG prof.c ws2_32.lib /Fe:prof.dll
prof.c
prof.c(385): warning C5274: behavior change: _Alignas no longer applies to the type '<unnamed-tag>' (only applies to declared data objects)
   Creating library prof.lib and object prof.exp
prof.obj : error LNK2019: unresolved external symbol _fsync referenced in function _destroy
prof.dll : fatal error LNK1120: 1 unresolved externals

Linux

aa07@AA07-C:/mnt/c/Users/AffectedArc07/Documents/GitHub/Parastuff/ParaByondTracy$ cmake .
-- The C compiler identification is GNU 9.4.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Configuring done (1.4s)
-- Generating done (0.1s)
-- Build files have been written to: /mnt/c/Users/AffectedArc07/Documents/GitHub/Parastuff/ParaByondTracy
aa07@AA07-C:/mnt/c/Users/AffectedArc07/Documents/GitHub/Parastuff/ParaByondTracy$ cmake --build . --config Release
[ 50%] Building C object CMakeFiles/byond_tracy.dir/prof.c.o
/mnt/c/Users/AffectedArc07/Documents/GitHub/Parastuff/ParaByondTracy/prof.c:196:19: error: missing binary operator before token "("
  196 | # if __has_builtin(__builtin_memcpy)
      |                   ^
/mnt/c/Users/AffectedArc07/Documents/GitHub/Parastuff/ParaByondTracy/prof.c:201:19: error: missing binary operator before token "("
  201 | # if __has_builtin(__builtin_memset)
      |                   ^
/mnt/c/Users/AffectedArc07/Documents/GitHub/Parastuff/ParaByondTracy/prof.c:206:19: error: missing binary operator before token "("
  206 | # if __has_builtin(__builtin_memcmp)
      |                   ^
make[2]: *** [CMakeFiles/byond_tracy.dir/build.make:76: CMakeFiles/byond_tracy.dir/prof.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:83: CMakeFiles/byond_tracy.dir/all] Error 2
make: *** [Makefile:91: all] Error 2
aa07@AA07-C:/mnt/c/Users/AffectedArc07/Documents/GitHub/Parastuff/ParaByondTracy$

I think I am missing something

@Bizzonium
Copy link
Copy Markdown
Author

Try to build it with cmake

@Bizzonium
Copy link
Copy Markdown
Author

oh, hmm

@Bizzonium
Copy link
Copy Markdown
Author

Bizzonium commented Jul 14, 2024

cmake version 3.28.1
image

@Bizzonium
Copy link
Copy Markdown
Author

What cmake version do you have?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants