fix: Fix JSON encoding of undefined notification entities#99
Merged
davidgrayston-paddle merged 1 commit intomainfrom Jun 10, 2025
Merged
fix: Fix JSON encoding of undefined notification entities#99davidgrayston-paddle merged 1 commit intomainfrom
davidgrayston-paddle merged 1 commit intomainfrom
Conversation
davidgrayston-paddle
force-pushed
the
fix/notification-json-encoding
branch
from
cf6c99a to
f985cd0
Compare
davidgrayston-paddle
force-pushed
the
fix/notification-json-encoding
branch
from
f985cd0 to
545ad31
Compare
| "region": "NY", | ||
| "status": "active", | ||
| "created_at": "2024-04-12T06:42:58.785Z", | ||
| "created_at": "2024-04-12T06:42:58.785000Z", |
Contributor
Author
There was a problem hiding this comment.
Fixtures updated to have consistent timestamp precision so that they can be compared with JSON encoded entities in tests.
davidgrayston-paddle
force-pushed
the
fix/notification-json-encoding
branch
from
545ad31 to
c1997bd
Compare
Comment on lines
+44
to
+45
| "tax_rates_used": null, | ||
| "type": null |
Contributor
Author
There was a problem hiding this comment.
Added default nullable properties so that the fixtures can be compared with JSON encoded entities in tests.
davidgrayston-paddle
force-pushed
the
fix/notification-json-encoding
branch
from
c1997bd to
3c421c1
Compare
davidgrayston-paddle
force-pushed
the
fix/notification-json-encoding
branch
from
3c421c1 to
c1d1960
Compare
davidgrayston-paddle
force-pushed
the
fix/notification-json-encoding
branch
from
c1d1960 to
caa8818
Compare
mikeymike
approved these changes
Jun 10, 2025
vifer
approved these changes
Jun 10, 2025
davidgrayston-paddle
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
paddle_billing.Notifications.Entities.UndefinedEntitynow implementsto_jsonand can be encoded usingpaddle_billing.Json.PayloadEncoder