Mhwc 161 navigation and workflow integration

[abhilashkadu-tekdi]

JIRA ID: 161

Enable navigation to the previous page after Case Identification with mandatory field validation and referral capture

---

✅ Type of Change

• 🐞 Bug fix (non-breaking change which resolves an issue)
• ✨ New feature (non-breaking change which adds functionality)
• 🔥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
• 🛠 Refactor (change that is neither a fix nor a new feature)
• ⚙️ Config change (configuration file or build script updates)
• 📚 Documentation (updates to docs or readme)
• 🧪 Tests (adding new or updating existing tests)
• 🎨 UI/UX (changes that affect the user interface)
• 🚀 Performance (improves performance)
• 🧹 Chore (miscellaneous changes that don't modify src or test files)

---

ℹ️ Additional Information

Please describe how the changes were tested, and include any relevant screenshots, logs, or other information that provides additional context.

Summary by CodeRabbit

• New Features
  • Enhanced form validation in the ophthalmic screening process to detect and report missing mandatory fields before saving.
  • Improved user experience with automatic navigation to incomplete fields when attempting to save, including visual feedback and automatic focus.
  • Updated UI interactions to provide clearer guidance on required form completion.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

📝 Walkthrough

Walkthrough

The changes implement pre-save validation for ophthalmic screening forms. The ViewModel introduces a MissingField enum and validation logic to identify incomplete mandatory fields. The Fragment handles missing fields by displaying guidance (toast notification, scrolling to field, and focusing it). The layout is updated to enable programmatic scrolling and removes data-binding for button state.

Changes

Cohort / File(s)	Summary
Validation Logic app/src/main/java/org/piramalswasthya/cho/ui/ophthalmic_screening/OphthalmicScreeningViewModel.kt	Added MissingField enum, getMissingMandatoryField() function, and helper methods (areVisibleSubFieldsAnswered, getMissingSubField) to compute missing mandatory fields. Integrated validation triggers after symptom/setter updates (setCataractSymptoms, setGlaucomaSymptoms, setDrSymptoms, setPresbyopiaSymptoms, setTrachomaStatus, setCornealDiseaseType, setVitaminADeficiency).
UI Validation Handling app/src/main/java/org/piramalswasthya/cho/ui/ophthalmic_screening/OphthalmicScreeningFragment.kt	Added pre-save validation in navigateAfterSave that queries ViewModel for missing mandatory fields. Introduced handleMissingField to map missing fields to string resources and focusable views, show toast, scroll to field, and focus it. Added ScrollView import for programmatic scrolling.
Layout Updates app/src/main/res/layout/fragment_ophthalmic_screening.xml	Added android:id="@+id/scroll_view" to ScrollView for programmatic access. Removed android:enabled data-binding from btn_next button.

Sequence Diagram

sequenceDiagram
    actor User
    participant Fragment as OphthalmicScreeningFragment
    participant ViewModel as OphthalmicScreeningViewModel
    participant UI as ScrollView/Toast

    User->>Fragment: Click Save Button
    Fragment->>ViewModel: getMissingMandatoryField()
    ViewModel->>ViewModel: Check mandatory fields
    ViewModel->>ViewModel: Validate sub-fields
    ViewModel-->>Fragment: MissingField (if any)
    
    alt Missing Field Found
        Fragment->>Fragment: handleMissingField(missingField)
        Fragment->>UI: Show Toast with Field Name
        Fragment->>UI: Scroll to Field
        Fragment->>UI: Focus on Field
    else No Missing Fields
        Fragment->>Fragment: navigateAfterSave()
    end

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 A form validation quest, we humbly present,
With missing fields caught before they're sent,
Toast messages guide, and scrolls take the lead,
While focus finds each field users need,
No data shall slip through this rabbit-reviewed gate! 🥕✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title 'Mhwc 161 navigation and workflow integration' is vague and generic, using technical identifiers without conveying what the specific changes accomplish.	Use a more descriptive title that clarifies the main change, such as 'Add mandatory field validation and auto-focus for ophthalmic screening form' or 'Implement validation and navigation flow for case identification to vitals/prescription screens'.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch mhwc-161-navigation-and-workflow-integration

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[abhilashkadu-tekdi]

@coderabbiteai review the changed files

[coderabbitai]

@abhilashkadu-tekdi, I'll review the changed files in this PR for you.

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

app/src/main/java/org/piramalswasthya/cho/ui/ophthalmic_screening/OphthalmicScreeningViewModel.kt (1)

541-575: Avoid rule drift between validate() and getMissingMandatoryField().

Both encode required-field logic; future changes could diverge. Consider deriving one from the other (shared helper or a single source of truth) to keep behavior consistent.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@app/src/main/java/org/piramalswasthya/cho/ui/ophthalmic_screening/OphthalmicScreeningViewModel.kt`
around lines 541 - 575, The validate() and getMissingMandatoryField() logic are
duplicated and risk drift; refactor so there is a single source of truth:
extract the required-field decision logic into a shared private helper (e.g., a
function like determineMissingField(reason, diabetic, rightVA, leftVA,
nearVaValue, caseIds, chart, screening) or reuse validate() to produce a
structured result) and have both getMissingMandatoryField() call that helper (or
map validate()'s result to MissingField) instead of duplicating checks; refer to
getMissingMandatoryField, validate, getMissingSubField and the helpers
isVisualImpairment/isNearVAReduced when locating and consolidating the logic.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In
`@app/src/main/java/org/piramalswasthya/cho/ui/ophthalmic_screening/OphthalmicScreeningFragment.kt`:
- Around line 203-228: handleMissingField currently scrolls using
viewToFocus.top which is in local parent coordinates and mispositions deeply
nested controls; replace that logic to compute the absolute Y using
viewToFocus.getLocationInWindow(intArray) (or getLocationOnScreen) and the
ScrollView's window position fetched via
binding.root.findViewById<ScrollView>(R.id.scroll_view) so you scroll to (viewY
- scrollViewY) (plus a small offset) and then call smoothScrollTo and
requestFocus on viewToFocus; update references in OphthalmicScreeningFragment's
handleMissingField to use
binding.root.findViewById<ScrollView>(R.id.scroll_view) and
viewToFocus.getLocationInWindow(...) rather than viewToFocus.top.

---

Nitpick comments:
In
`@app/src/main/java/org/piramalswasthya/cho/ui/ophthalmic_screening/OphthalmicScreeningViewModel.kt`:
- Around line 541-575: The validate() and getMissingMandatoryField() logic are
duplicated and risk drift; refactor so there is a single source of truth:
extract the required-field decision logic into a shared private helper (e.g., a
function like determineMissingField(reason, diabetic, rightVA, leftVA,
nearVaValue, caseIds, chart, screening) or reuse validate() to produce a
structured result) and have both getMissingMandatoryField() call that helper (or
map validate()'s result to MissingField) instead of duplicating checks; refer to
getMissingMandatoryField, validate, getMissingSubField and the helpers
isVisualImpairment/isNearVAReduced when locating and consolidating the logic.

---

ℹ️ Review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eab2859 and 7050304.

📒 Files selected for processing (3)

• app/src/main/java/org/piramalswasthya/cho/ui/ophthalmic_screening/OphthalmicScreeningFragment.kt
• app/src/main/java/org/piramalswasthya/cho/ui/ophthalmic_screening/OphthalmicScreeningViewModel.kt
• app/src/main/res/layout/fragment_ophthalmic_screening.xml

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud