Skip to content

fix: facility hierarchy and facility type management #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vishwab1 merged 18 commits into from
Mar 18, 2026

fix: add logs/ to .gitignore

7ef402c
Select commit
Loading
Failed to load commit list.
Merged

fix: facility hierarchy and facility type management #125

fix: add logs/ to .gitignore
7ef402c
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Mar 18, 2026 in 32s

Quality Gate failed

Failed conditions
3.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Annotations

Check warning on line 75 in src/main/java/com/iemr/admin/service/store/StoreService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace generic exceptions with specific library exceptions or a custom exception. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_Admin-API&issues=AZ0BMqpcmjzjByUrfX7y&open=AZ0BMqpcmjzjByUrfX7y&pullRequest=125

Check warning on line 55 in src/main/java/com/iemr/admin/controller/employeemaster/AshaSupervisorMappingController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_Admin-API&issues=AZ0BMqqZmjzjByUrfX8B&open=AZ0BMqqZmjzjByUrfX8B&pullRequest=125

Check warning on line 352 in src/main/java/com/iemr/admin/service/employeemaster/EmployeeMasterServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace generic exceptions with specific library exceptions or a custom exception. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_Admin-API&issues=AZ0BMqnAmjzjByUrfX7f&open=AZ0BMqnAmjzjByUrfX7f&pullRequest=125

Check warning on line 194 in src/main/java/com/iemr/admin/controller/employeemaster/AshaSupervisorMappingController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace "@RequestMapping(method = RequestMethod.POST)" with "@PostMapping" 

See more on https://sonarcloud.io/project/issues?id=PSMRI_Admin-API&issues=AZ0BMqqZmjzjByUrfX8K&open=AZ0BMqqZmjzjByUrfX8K&pullRequest=125

Check warning on line 120 in src/main/java/com/iemr/admin/controller/employeemaster/AshaSupervisorMappingController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace "@RequestMapping(method = RequestMethod.POST)" with "@PostMapping" 

See more on https://sonarcloud.io/project/issues?id=PSMRI_Admin-API&issues=AZ0BMqqZmjzjByUrfX8G&open=AZ0BMqqZmjzjByUrfX8G&pullRequest=125

Check warning on line 1049 in src/main/java/com/iemr/admin/service/employeemaster/EmployeeMasterServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace generic exceptions with specific library exceptions or a custom exception. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_Admin-API&issues=AZ0BMqnAmjzjByUrfX7k&open=AZ0BMqnAmjzjByUrfX7k&pullRequest=125

Check warning on line 387 in src/main/java/com/iemr/admin/service/employeemaster/EmployeeMasterServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace generic exceptions with specific library exceptions or a custom exception. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_Admin-API&issues=AZ0BMqnAmjzjByUrfX7i&open=AZ0BMqnAmjzjByUrfX7i&pullRequest=125

Check warning on line 209 in src/main/java/com/iemr/admin/service/employeemaster/EmployeeMasterServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_Admin-API&issues=AZ0BMqnAmjzjByUrfX7p&open=AZ0BMqnAmjzjByUrfX7p&pullRequest=125

Check warning on line 167 in src/main/java/com/iemr/admin/controller/facilitytype/FacilitytypeController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace generic exceptions with specific library exceptions or a custom exception. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_Admin-API&issues=AZ0BMqsmmjzjByUrfX8N&open=AZ0BMqsmmjzjByUrfX8N&pullRequest=125

Check warning on line 1057 in src/main/java/com/iemr/admin/service/employeemaster/EmployeeMasterServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace generic exceptions with specific library exceptions or a custom exception. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_Admin-API&issues=AZ0BMqnAmjzjByUrfX7l&open=AZ0BMqnAmjzjByUrfX7l&pullRequest=125

Check failure on line 379 in src/main/java/com/iemr/admin/service/employeemaster/EmployeeMasterServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "asha supervisor" 3 times. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_Admin-API&issues=AZ0BMqnAmjzjByUrfX7n&open=AZ0BMqnAmjzjByUrfX7n&pullRequest=125

Check failure on line 270 in src/main/java/com/iemr/admin/service/store/StoreServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 35 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_Admin-API&issues=AZ0BMqqJmjzjByUrfX77&open=AZ0BMqqJmjzjByUrfX77&pullRequest=125

Check warning on line 51 in src/main/java/com/iemr/admin/service/employeemaster/AshaSupervisorMappingServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_Admin-API&issues=AZ0BMqo0mjzjByUrfX7v&open=AZ0BMqo0mjzjByUrfX7v&pullRequest=125

Check warning on line 52 in src/main/java/com/iemr/admin/controller/employeemaster/AshaSupervisorMappingController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_Admin-API&issues=AZ0BMqqZmjzjByUrfX8A&open=AZ0BMqqZmjzjByUrfX8A&pullRequest=125

Check warning on line 287 in src/main/java/com/iemr/admin/service/store/StoreServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace generic exceptions with specific library exceptions or a custom exception. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_Admin-API&issues=AZ0BMqqJmjzjByUrfX71&open=AZ0BMqqJmjzjByUrfX71&pullRequest=125

Check failure on line 382 in src/main/java/com/iemr/admin/service/store/StoreServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 53 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_Admin-API&issues=AZ0BMqqJmjzjByUrfX78&open=AZ0BMqqJmjzjByUrfX78&pullRequest=125

Check warning on line 70 in src/main/java/com/iemr/admin/controller/employeemaster/AshaSupervisorMappingController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Merge this if statement with the enclosing one. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_Admin-API&issues=AZ0BMqqZmjzjByUrfX79&open=AZ0BMqqZmjzjByUrfX79&pullRequest=125

Check warning on line 54 in src/main/java/com/iemr/admin/controller/facilitytype/FacilitytypeController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_Admin-API&issues=AZ0BMqsmmjzjByUrfX8O&open=AZ0BMqsmmjzjByUrfX8O&pullRequest=125

Check failure on line 1017 in src/main/java/com/iemr/admin/service/employeemaster/EmployeeMasterServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Admin" 7 times. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_Admin-API&issues=AZ0BMqnAmjzjByUrfX7o&open=AZ0BMqnAmjzjByUrfX7o&pullRequest=125

Check warning on line 58 in src/main/java/com/iemr/admin/controller/employeemaster/AshaSupervisorMappingController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_Admin-API&issues=AZ0BMqqZmjzjByUrfX8C&open=AZ0BMqqZmjzjByUrfX8C&pullRequest=125

Check warning on line 273 in src/main/java/com/iemr/admin/service/store/StoreServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace generic exceptions with specific library exceptions or a custom exception. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_Admin-API&issues=AZ0BMqqJmjzjByUrfX70&open=AZ0BMqqJmjzjByUrfX70&pullRequest=125

Check warning on line 356 in src/main/java/com/iemr/admin/service/store/StoreServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace generic exceptions with specific library exceptions or a custom exception. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_Admin-API&issues=AZ0BMqqJmjzjByUrfX72&open=AZ0BMqqJmjzjByUrfX72&pullRequest=125

Check warning on line 393 in src/main/java/com/iemr/admin/service/employeemaster/EmployeeMasterServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace generic exceptions with specific library exceptions or a custom exception. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_Admin-API&issues=AZ0BMqnAmjzjByUrfX7j&open=AZ0BMqnAmjzjByUrfX7j&pullRequest=125

Check warning on line 68 in src/main/java/com/iemr/admin/service/store/StoreServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_Admin-API&issues=AZ0BMqqJmjzjByUrfX76&open=AZ0BMqqJmjzjByUrfX76&pullRequest=125

Check warning on line 45 in src/main/java/com/iemr/admin/service/employeemaster/AshaSupervisorMappingServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_Admin-API&issues=AZ0BMqo0mjzjByUrfX7t&open=AZ0BMqo0mjzjByUrfX7t&pullRequest=125
View more details on SonarQubeCloud