add nth method to restrict assert on a specific call number.#4
Open
vhenriet-sfy wants to merge 1 commit intomasterfrom
Open
add nth method to restrict assert on a specific call number.#4vhenriet-sfy wants to merge 1 commit intomasterfrom
vhenriet-sfy wants to merge 1 commit intomasterfrom
Conversation
This is used to check call order on the same spy.
sveyret
reviewed
Jun 20, 2025
Comment on lines
+57
to
59
| controlData:assert(controlData.actual:called_with(arguments, controlData.spyCallNumber), FailureMessage( | ||
| 'expected spy for {actualFunction} to have been called with arguments {!arguments}', params), FailureMessage( | ||
| 'expected spy for {actualFunction} to not have been called with arguments {!arguments}', params)) |
Collaborator
There was a problem hiding this comment.
Je rajouterai bien une information pour le nth :
Suggested change
| controlData:assert(controlData.actual:called_with(arguments, controlData.spyCallNumber), FailureMessage( | |
| 'expected spy for {actualFunction} to have been called with arguments {!arguments}', params), FailureMessage( | |
| 'expected spy for {actualFunction} to not have been called with arguments {!arguments}', params)) | |
| params.nth = "" | |
| if controlData.spyCallNumber then | |
| params.nth = "call #" .. controlData.spyCallNumber .. " of " | |
| controlData:assert(controlData.actual:called_with(arguments, controlData.spyCallNumber), FailureMessage( | |
| 'expected {nth}spy for {actualFunction} to have been called with arguments {!arguments}', params), FailureMessage( | |
| 'expected {nth}spy for {actualFunction} to not have been called with arguments {!arguments}', params)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is used to check call order on the same spy.