Support Apollo 2 / Vulcan 1.13#21
Open
eric-burel wants to merge 19 commits intoOrigenStudio:developfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #20. Ungoing update to Apollo2 / Vulcan 1.13
Hopefully those updates should allow some code simplification, however there are many breaking changes. I've got a non-buggy workflow but still not working as expected.
Edit: it seems to work ok actually, now I need to update the UI. Updates seems to create new files all the time, and removal does not seem to be triggered, I'll also try to fix this.
Edit 2: @ochicf it now works OK in my app with no breaking change. Vulcan needs this PR to be merged for this new version to work, it enhance the Apollo 2 server to allow file upload with the new API. I hope to merge it within a few days.
Also handlers now correctly remove stale files when you replace or delete a file.
I've also modified the UI a bit to make it more replaceable. I uses similar patterns as the ones we are progressively introducing in the core to allow replacement of core components without rewriting their logic. It's a bit verbose but it seems to do the trick, I've managed to create a Material UI input.
Only thing I did not test is multiple file upload. I've updated the code but I am not 100% it will run as expected, to be tested. Also filecheck is ran client side but not server side, that's something I also hope too tackle soon because it's necessary to have a secure system. Eventually, a few file might be deleted but I was not 100% sure (eg https://github.com/OrigenStudio/vulcan-files/blob/master/lib/client/interface.js), since now
apollo-upload-clientdoes the heavy lifting client side.The PR merges to the
developbranch, however it may be better to create anapollo2branch to support both legacy Vulcan apps and new Vulcan apps (> 1.13)?