Fix file info path during edit when not multiple#18
Open
eric-burel wants to merge 1 commit intoOrigenStudio:developfrom
Open
Fix file info path during edit when not multiple#18eric-burel wants to merge 1 commit intoOrigenStudio:developfrom
eric-burel wants to merge 1 commit intoOrigenStudio:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I figured out a first bug: when previewing a single file, it still try to find the url at
['yourResolverName', 0]as a default, even if your value is not an array.Checking if the input allow multiple files seems to fix this.
Also, I have tried to write my own
previewFromValueand add it in the schema, as you do here: https://github.com/OrigenStudio/vulcan-files-simple-example/blob/master/packages/example-instagram/lib/modules/pics/schema.js#L56However,
valueis equal to the input props (and props is not defined). I could not trace where the call is made even when searching all references to this method, which sounds weird.