Conversation
…into release-v1.1
…into release-v1.1
…into release-v1.1
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-v1.1 #285 +/- ##
================================================
- Coverage 89.87% 89.71% -0.16%
================================================
Files 19 19
Lines 1787 1760 -27
Branches 484 481 -3
================================================
- Hits 1606 1579 -27
Misses 168 168
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Removes bitwise operations from the SD29x9 fixed-point type in openzeppelin_fp_math, keeping bitwise helpers only on UD30x9, and updates docs/changelog accordingly.
Changes:
- Removed
SD29x9bitwise APIs (and/or/xor/not, shifts) from the public surface and base implementation. - Deleted the
SD29x9bitwise test module. - Updated READMEs, changelog entry, and
Move.lockto reflect the new API surface/environment pinning.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| math/README.md | Updates package highlight text to reflect UD30x9-only bitwise helpers. |
| math/fixed_point/tests/sd29x9_tests/bitwise_tests.move | Removes SD29x9 bitwise tests corresponding to removed APIs. |
| math/fixed_point/sources/sd29x9/sd29x9.move | Removes public use re-exports for SD29x9 bitwise functions. |
| math/fixed_point/sources/sd29x9/sd29x9_base.move | Deletes the SD29x9 bitwise helper implementations. |
| math/fixed_point/README.md | Updates documentation to remove SD29x9 bitwise claims and clarify UD30x9 behavior. |
| math/fixed_point/Move.lock | Adds mainnet-pinned entries for fixed_point package dependencies. |
| CHANGELOG.md | Records the breaking removal of SD29x9 bitwise operations under Unreleased. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary by CodeRabbit
Breaking Changes
Documentation