Skip to content

Remove SD29x9 bitwise operations#285

Open
ericnordelo wants to merge 5 commits intorelease-v1.1from
refactor/remove-sd-bitwise-operations
Open

Remove SD29x9 bitwise operations#285
ericnordelo wants to merge 5 commits intorelease-v1.1from
refactor/remove-sd-bitwise-operations

Conversation

@ericnordelo
Copy link
Copy Markdown
Member

@ericnordelo ericnordelo commented Apr 1, 2026

Summary by CodeRabbit

  • Breaking Changes

    • Removed bitwise operations from the SD29x9 fixed-point type.
  • Documentation

    • Updated package documentation to clarify bitwise operation availability, specifying that bitwise utilities are exclusive to the UD30x9 fixed-point type.

Copilot AI review requested due to automatic review settings April 1, 2026 11:31
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 1, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 265d2594-7c4e-43ea-afb1-ca8ef6d491d2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/remove-sd-bitwise-operations

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.71%. Comparing base (e8dea76) to head (e7f22ab).

Additional details and impacted files
@@               Coverage Diff                @@
##           release-v1.1     #285      +/-   ##
================================================
- Coverage         89.87%   89.71%   -0.16%     
================================================
  Files                19       19              
  Lines              1787     1760      -27     
  Branches            484      481       -3     
================================================
- Hits               1606     1579      -27     
  Misses              168      168              
  Partials             13       13              
Flag Coverage Δ
contracts/access 44.87% <ø> (ø)
math/core 86.12% <ø> (ø)
math/fixed_point 56.31% <ø> (-2.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes bitwise operations from the SD29x9 fixed-point type in openzeppelin_fp_math, keeping bitwise helpers only on UD30x9, and updates docs/changelog accordingly.

Changes:

  • Removed SD29x9 bitwise APIs (and/or/xor/not, shifts) from the public surface and base implementation.
  • Deleted the SD29x9 bitwise test module.
  • Updated READMEs, changelog entry, and Move.lock to reflect the new API surface/environment pinning.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
math/README.md Updates package highlight text to reflect UD30x9-only bitwise helpers.
math/fixed_point/tests/sd29x9_tests/bitwise_tests.move Removes SD29x9 bitwise tests corresponding to removed APIs.
math/fixed_point/sources/sd29x9/sd29x9.move Removes public use re-exports for SD29x9 bitwise functions.
math/fixed_point/sources/sd29x9/sd29x9_base.move Deletes the SD29x9 bitwise helper implementations.
math/fixed_point/README.md Updates documentation to remove SD29x9 bitwise claims and clarify UD30x9 behavior.
math/fixed_point/Move.lock Adds mainnet-pinned entries for fixed_point package dependencies.
CHANGELOG.md Records the breaking removal of SD29x9 bitwise operations under Unreleased.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants