Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #171 +/- ##
=======================================
Coverage 89.88% 89.88%
=======================================
Files 19 19
Lines 1790 1790
Branches 484 484
=======================================
Hits 1609 1609
Misses 168 168
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
WARNING
Proposal
How this is imagined to behave:
mainis updated (alternative is to run every X days/weeks to accumulate enough meaningful changes)Potential Issues
1. We already have a tool that does exactly this, it's called X.
Awesome, let's integrate that instead, and close this PR!
2. The CI job implementation actually has problem with X, it should do Y instead.
It's excellent that you noticed this problem and suggested an improvement! The better we make the CI job now, the more bugs we'll catch when it runs later.
3. The CI job turns out to have too many false positives OR reports too few basic vulnerabilities that are later surfaced in the actual audit.
We try to improve the prompt to improve the job's effectiveness. In the extreme case, we determine the CI job is more often than not useless, so we remove it, and call it a day.
4. The risk of leaking sensitive data is too great to allow running such a CI job.
Fair critique and very important! If possible, let's try to make the LLM sandboxed enough that we feel at ease. If not possible, or we feel to uncomfortable, we shouldn't just close the PR without merging and that's that.