Skip to content

Add embedding option in text editor#5948

Draft
Borreg0 wants to merge 17 commits intoOpenSlides:mainfrom
Borreg0:5902-InternalReferences
Draft

Add embedding option in text editor#5948
Borreg0 wants to merge 17 commits intoOpenSlides:mainfrom
Borreg0:5902-InternalReferences

Conversation

@Borreg0
Copy link
Copy Markdown
Contributor

@Borreg0 Borreg0 commented Mar 5, 2026

Closes #5902

@Borreg0 Borreg0 self-assigned this Mar 5, 2026
@Borreg0 Borreg0 added the feature label Mar 5, 2026
@Borreg0 Borreg0 marked this pull request as draft March 5, 2026 09:58
@Borreg0 Borreg0 marked this pull request as ready for review March 6, 2026 11:07
@Borreg0 Borreg0 assigned bastianjoel and Elblinator and unassigned Borreg0 Mar 6, 2026
@bastianjoel bastianjoel assigned Borreg0 and unassigned bastianjoel and Elblinator Mar 9, 2026
@Borreg0 Borreg0 assigned bastianjoel and Elblinator and unassigned Borreg0 Mar 9, 2026
Copy link
Copy Markdown
Member

@Elblinator Elblinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The new feature should still be in the dialog
  • Both options should have a keyboard_arrow_down/keyboard_arrow_up icon (and the function of such)
  • Both titles should have the same colour and NOT the disabled colour
  • "Insert/edit link" should be changed to "Insert/edit external link"
  • The option to add Home is missing right now
  • The option to add more than one object is not working
    • If you look at a motion with this functionality you can add a string or several motions.
    • if you use this function:
      • then you need to change the title to "Link a topic/motion/assignment"
      • AND after you added one and then press the option again you need to add a NEW link. Right now after adding one you are visually one space behind the link, and if the option is pressed again the old link is change to the new link. Only if you are on the link (cursor directly on the last/first letter or in between) the link should be changed.
  • Remove the done/clear option and if an object was selected then update the string in the selected item box directly
  • The issue with the updated link if you visually are at a different place should be fixed regardless of whether or not the dialog can create one vs several links

@Elblinator Elblinator assigned Borreg0 and unassigned bastianjoel and Elblinator Mar 9, 2026
@Borreg0 Borreg0 marked this pull request as draft March 12, 2026 09:26
@Elblinator
Copy link
Copy Markdown
Member

We talked about this issue internally and visually want something else then described above:

  • The new feature should still be in the dialog
  • Both options should have a keyboard_arrow_down/keyboard_arrow_up icon (and the function of such)
  • Both titles should have the same colour and NOT the disabled colour
  • "Insert/edit link" should be changed to "Insert/edit external link"

@Borreg0 Borreg0 marked this pull request as ready for review March 16, 2026 10:48
@Borreg0 Borreg0 assigned bastianjoel and Elblinator and unassigned Borreg0 Mar 16, 2026
@Borreg0 Borreg0 requested a review from Elblinator March 16, 2026 10:48
Copy link
Copy Markdown
Member

@Elblinator Elblinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A) The links form a topic are currently not working corretly.
Please remove any non topic from the topic selection (e.g. a motion if it's on the topic-list)

B) give the element with the class "reference" the function to open/close the menu (in cotrast to just the keyboard_arrow_up/_down

C) Disable this function for the motion editor (ANY editor which is in the motion/amendment view

D) If you navigate into the dialog with only key inputs (without the mouse) you focus a wrong element in the beginning.
After implementing B) that should again have changed, The wanted behaviour is:

  1. after opening the dialog
    If you have both option (see C) )
  2. Then your focus should be on The first title/arrow and if enter is pressed then the option should open
  3. If you press tab then you should navigate to other title/arrow and if enter is pressed then the option should open etc.
  4. The next tab should navgigate to the buttons

If you have just one option (see C) )
2. The focus should be immediately on the url input field
3. Tab goes to the "Text to display" input etc.

E) If you inserted an object via your new function and decide that you want to use the other url function, then you have to close and open the dialog again and then you can insert a url. Please make a suggestion on how to prevent the needed closing of the dialog

@Elblinator Elblinator assigned Borreg0 and unassigned Elblinator and bastianjoel Mar 17, 2026
@Borreg0
Copy link
Copy Markdown
Contributor Author

Borreg0 commented Mar 17, 2026

About point E):

The options are enabled again when another radio-button is selected. I will add a reset button again so it's more intuitive for the user.

@Borreg0 Borreg0 marked this pull request as draft March 17, 2026 14:43
@Borreg0 Borreg0 force-pushed the 5902-InternalReferences branch from 8cf1663 to 67f752e Compare March 18, 2026 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Embedding of motion/assignment/topic links in home/topic text

3 participants