Draft
Conversation
Borreg0
added
enhancement
Borreg0
force-pushed
the
5870-AgendaExportRework
branch
from
2641019 to
c64a1c5
Compare
4 tasks
4 tasks
Member
|
Given that the export of the motion list was not working before the agenda export change in october I would recommend fixing that part of the export in a later issue and test this issue as is. |
MSoeb
requested changes
Mar 18, 2026
MSoeb
left a comment
MSoeb
left a comment
There was a problem hiding this comment.
- The top margin needs to be reset to its original value. I forgot that this setting could be adjusted. So please undo this change. (I’m sorry.)
- Spacing between headings: Reduce the spacing by half.
- Indentation: Indentation is no longer correct starting from the third level. In example below Antrag 03 is on third level but not indented.--> Indentation hierarchy should correspond correctly to its level.
- The spacing between the agenda (heading) and the first agenda item is too small. --> Use the current spacing between agenda items (current value of number 2) at this point.
Image for help:
Additionally an improvement for content with text is needed:
- Alignment of topic text with topic heading: Heading and text should be aligned.
|
About lists: Yes, you can do this later. |
Borreg0
force-pushed
the
5870-AgendaExportRework
branch
from
b176b5e to
64a75a3
Compare
bastianjoel
requested changes
Mar 26, 2026
...pages/agenda/services/agenda-pdf-catalog-export.service/agenda-pdf-catalog-export.service.ts
Outdated
Show resolved
Hide resolved
...pages/agenda/services/agenda-pdf-catalog-export.service/agenda-pdf-catalog-export.service.ts
Outdated
Show resolved
Hide resolved
...pages/agenda/services/agenda-pdf-catalog-export.service/agenda-pdf-catalog-export.service.ts
Outdated
Show resolved
Hide resolved
...pages/agenda/services/agenda-pdf-catalog-export.service/agenda-pdf-catalog-export.service.ts
Outdated
Show resolved
Hide resolved
...pages/agenda/services/agenda-pdf-catalog-export.service/agenda-pdf-catalog-export.service.ts
Outdated
Show resolved
Hide resolved
...pages/agenda/services/agenda-pdf-catalog-export.service/agenda-pdf-catalog-export.service.ts
Outdated
Show resolved
Hide resolved
...pages/agenda/services/agenda-pdf-catalog-export.service/agenda-pdf-catalog-export.service.ts
Outdated
Show resolved
Hide resolved
...pages/agenda/services/agenda-pdf-catalog-export.service/agenda-pdf-catalog-export.service.ts
Outdated
Show resolved
Hide resolved
added 2 commits
March 27, 2026 10:45
…into 5870-AgendaExportRework
bastianjoel
requested changes
Mar 27, 2026
client/src/app/site/pages/meetings/pages/agenda/agenda.subscription.ts
Outdated
Show resolved
Hide resolved
...pages/agenda/services/agenda-pdf-catalog-export.service/agenda-pdf-catalog-export.service.ts
Outdated
Show resolved
Hide resolved
...pages/agenda/services/agenda-pdf-catalog-export.service/agenda-pdf-catalog-export.service.ts
Outdated
Show resolved
Hide resolved
...pages/agenda/services/agenda-pdf-catalog-export.service/agenda-pdf-catalog-export.service.ts
Outdated
Show resolved
Hide resolved
Comment on lines
+357
to
+401
| const moderationText = { | ||
| text: entry | ||
| }; | ||
| const text = this.translate.instant(`Moderation note`); | ||
| const style = [this.getStyle(`header3`), this.getStyle(`margin-body-text`)]; | ||
| const margin: [ | ||
| [number, number, number, number], | ||
| [number, number, number, number], | ||
| [number, number, number, number], | ||
| [number, number, number, number] | ||
| ] = [ | ||
| [20, 10, 0, 0], | ||
| [20, 10, 0, 0], | ||
| this.getStyle(`margin-header3`), | ||
| this.getStyle(`margin-moderation-note`) | ||
| ]; | ||
| // Indents the moderation note inside a subitem | ||
| if (agendaItem.level > 0) { | ||
| margin[0][0] = margin[0][0] + agendaItem.level * 10; | ||
| return [ | ||
| { | ||
| text: text, | ||
| style: style[0], | ||
| margin: margin[0] | ||
| }, | ||
| { | ||
| text: moderationText, | ||
| style: style[1], | ||
| margin: margin[0] | ||
| } | ||
| ]; | ||
| } else { | ||
| return [ | ||
| { | ||
| text: text, | ||
| style: style[0], | ||
| margin: margin[2] | ||
| }, | ||
| { | ||
| text: moderationText, | ||
| style: style[1], | ||
| margin: margin[3] | ||
| } | ||
| ]; | ||
| } |
...pages/agenda/services/agenda-pdf-catalog-export.service/agenda-pdf-catalog-export.service.ts
Outdated
Show resolved
Hide resolved
| case `agenda-title`: | ||
| return [0, 0, 0, 20]; | ||
| case `margin-header1`: | ||
| return [0, 0, 0, 0]; |
Member
There was a problem hiding this comment.
This does not seem right. Why even create a style when everything is zero?
| return [15, 10, 0, 5]; | ||
| case `margin-item`: | ||
| return [0, 0, 0, 5]; | ||
| return [0, 0, 0, 0]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5870
Additionally found: Lists are not exported at all in motions, topics or assignments. Normal text and raw html code is exported right. @MSoeb is it okay if it is fixed later in a separate issue? It is too complex for me right now, someone else needs to take over.