Allow more constellations for live voting#3425
Merged
hjanott merged 12 commits intoOpenSlides:mainfrom Mar 27, 2026
Merged
Conversation
MoonCubes
force-pushed
the
3396-live-voting
branch
from
5765954 to
8668e47
Compare
hjanott
requested changes
Mar 26, 2026
Member
hjanott
left a comment
hjanott
left a comment
There was a problem hiding this comment.
Good work. Many beautiful changes here. I have a few ideas and change requests.
A general idea could be to move the code duplication into a mixin.
I may have missed that some tests are already existing. If so just mention that.
MoonCubes
force-pushed
the
3396-live-voting
branch
from
02aacd9 to
2d384c1
Compare
hjanott
approved these changes
Mar 26, 2026
Member
hjanott
left a comment
hjanott
left a comment
There was a problem hiding this comment.
Just one more thing that can be improved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3396
needed for:
OpenSlides/openslides-client#5977