Conversation
TODO: Integrate by calling at the right places
hjanott
left a comment
hjanott
left a comment
There was a problem hiding this comment.
I like the general approach and have some suggestions. :)
|
|
||
| #raise MigrationException( | ||
| # f"pre check for migration {module_name} failed." | ||
| #) |
There was a problem hiding this comment.
I would honestly expect the modules function to already do so. No need for the flag.
| # TODO: removed commented out lines after review | ||
| # MigrationHelper.write_line is hardly usable when only the last | ||
| # line is output. |
There was a problem hiding this comment.
We can change this, but we would need to empty the streams buffer each time reading with truncate(0) and seek(0).
Still open: - StringIO stream: replace `getvalue` with appropriate `read` / `truncate` - Replace LINK
|
The PR for documentation of the Update to 4.3.0 is now open in main repo https://github.com/OpenSlides/OpenSlides/pull/7091/changes It Includes the file After that the only remaining TODO is:
|
Used for data validations after migration.
|
When calling Originally I was intending to do the pre-check early enough so this wouldn't happen. @hjanott if you find a way for pre-check to fail more gracefully, such that one could just add the missing env vars and call |
|
Please ping @m-schieder if this gets merged. |
3 participants
No description provided.