Reorganizing repo and drafting new data formats.#61
Draft
lmdiazangulo wants to merge 3 commits into58-major-redesignfrom
Draft
Reorganizing repo and drafting new data formats.#61lmdiazangulo wants to merge 3 commits into58-major-redesignfrom
lmdiazangulo wants to merge 3 commits into58-major-redesignfrom
Conversation
2ba0ea9 to
a252b58
Compare
… and material definitions
docs/tulip_data_format.md
Outdated
| - `[inductancePerMeter]` defined by a real representing transfer impedance inductance. Defaults to `0.0`. | ||
| - `[direction]` which can be `both`, `inwards`, or `outwards`. Indicating the type of coupling considered. Defaults to `both` meaning that fields can couple from the exterior to interior and the other way round. | ||
|
|
||
| Shields layers can never intersect ony other `shield` layer. They can be used in two ways: |
Collaborator
There was a problem hiding this comment.
there is a typo error ony => any
docs/tulip_data_format.md
Outdated
| - `<type>` a string with `conductor`, `shield`, `dielectric`, or `open`. Depending on their type they may need additional entries, as described below. | ||
|
|
||
| ### `conductor` | ||
| A conductor material can contain a `[resistancePerMeter]` or `[conductivity]`. The conductivity will be used to compute a resistance per meter for the conductor. |
Collaborator
There was a problem hiding this comment.
Just to clarify, are fields with both resistance and conductivity allowed? In that case, which one has preference?
Collaborator
Author
There was a problem hiding this comment.
No, just one is allowed. It says "or".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.