Open
Conversation
…s redundant function to count multiwire probes
lmdiazangulo
added a commit
that referenced
this pull request
Mar 19, 2026
…pdates documentation. MIsses MPI
…to have a resistance. Adds a large resistance in parallel to a current generator
Alberto-o
requested review from
Copilot and
lmdiazangulo
and removed request for
Copilot
lmdiazangulo
requested changes
Mar 29, 2026
| ], | ||
| "field": "current" | ||
| "field": "current", | ||
| "resistance" : 1.0e6 |
Contributor
There was a problem hiding this comment.
I think this should not appear if we define better the default behaviours. Also. 1 MOhm can be too little, depending on the case.
Collaborator
Author
There was a problem hiding this comment.
In this case, it is a generator on an interior point. Accordiing to the current rules, the resistance value is mandatory. If it intended to work as a current source with an "infinite" parallel resistor, the value should be 1e22.
If instead we are going to allow generators with no resistance in interior points, I will make 0/1e22 for V/I generators the default value
Corrects default values for current generator on terminations Adds call to errReport if interior voltage generator misses resistance Skips parallel resistor in current generator in spice if it 1e22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working on issue #276