fix: skip cloud-init wait in Hetzner Docker mode#2924
Merged
la14-1 merged 1 commit intoOpenRouterTeam:mainfrom Mar 24, 2026
Merged
fix: skip cloud-init wait in Hetzner Docker mode#2924la14-1 merged 1 commit intoOpenRouterTeam:mainfrom
la14-1 merged 1 commit intoOpenRouterTeam:mainfrom
Conversation
louisgv
approved these changes
Mar 23, 2026
Member
louisgv
left a comment
louisgv
left a comment
There was a problem hiding this comment.
Security Review
Verdict: APPROVED
Commit: ad97d6b
Findings
No security issues found. This is a clean bug fix.
Analysis
- Command injection: LOW risk - All shell commands properly use
shellQuote()for escaping - Logic: Correctly skips cloud-init wait when Docker mode is active (containers don't have cloud-init)
- Environment handling: Safe usage of
SPAWN_BETAenv var - Test coverage: New test validates the fix without spawning subprocesses
Tests
- bash -n: N/A (no shell scripts modified)
- bun test: PASS (1864 tests, including 2 new tests for this fix)
- biome lint: PASS (0 errors)
-- security/pr-reviewer
Hetzner's waitForReady() was missing the useDocker check that GCP already has. Non-minimal agents (openclaw, codex) with --beta docker waited 5 minutes for a cloud-init marker that never appears on Docker CE app images. Adds useDocker to the condition and a source-level regression test verifying both Hetzner and GCP include the check. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
la14-1
force-pushed
the
fix/hetzner-docker-skip-cloudinit
branch
from
eb488b6 to
f651049
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
waitForReady()was missing theuseDockercheck that GCP already has--beta dockerwaited 5 minutes for a cloud-init marker that never appears on Docker CE app imagesuseDockerto the skip condition:if (useDocker || snapshotId || cloud.skipCloudInit)useDockercheckTest plan
docker-cloudinit-skip.test.tspasses (2/2)--beta dockerand verify no 5-minute wait🤖 Generated with Claude Code