Reapply "build: fix rule for building dynamic files"#5707
Open
vtjnash wants to merge 1 commit intoOpenMathLib:developfrom
Open
Reapply "build: fix rule for building dynamic files"#5707vtjnash wants to merge 1 commit intoOpenMathLib:developfrom
vtjnash wants to merge 1 commit intoOpenMathLib:developfrom
Conversation
This reverts commit 7eab365 and fixes the pattern rule requirement "% must match a non-empty stem" to match at least '.' in the pattern. This whole file could actually be substantially simplified to just: %.$(SUFFIX): %.c $(CC) $(CFLAGS) -c $< -o $(@f) %.$(PSUFFIX): %.c $(CC) $(PFLAGS) -c $< -o $(@f) if desired to entirely avoid the copy-paste duplication, but the net effect is the same.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 7eab365 and fixes the pattern rule requirement "% must match a non-empty stem" to match at least '.' in the pattern.
This whole file could actually be substantially simplified to just:
if desired to entirely avoid the copy-paste duplication, but the net effect is the same.