Skip to content

Always send finalState #1333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
taylordowns2000 merged 2 commits into from
Mar 24, 2026
+11 −5
Merged

Always send finalState #1333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35c9488
send finalState anyway
taylordowns2000 Mar 24, 2026
cc1ffce
prep release
taylordowns2000 Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/ws-worker/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,17 @@
# ws-worker

## 1.23.1

### Patch Changes

- Even when sending final_dataclip_id, send finalState because it may be used by other consumers

## 1.23.0

### Minor Changes

- 01a05ff: on send complete, only send final_state for multi-leaf output state. For single-leaf runs, reutrn final_dataclip_id

## 1.22.3

### Patch Changes
Expand Down
2 changes: 1 addition & 1 deletion packages/ws-worker/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@openfn/ws-worker",
"version": "1.23.0",
"version": "1.23.1",
"description": "A Websocket Worker to connect Lightning to a Runtime Engine",
"main": "dist/index.js",
"type": "module",
Expand Down
3 changes: 1 addition & 2 deletions packages/ws-worker/src/events/run-complete.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,12 @@ export default async function onWorkflowComplete(

const payload: RunCompletePayload = {
timestamp: timeInMicroseconds(event.time),
final_state: result,
...reason,
};

if (isSingleLeaf) {
payload.final_dataclip_id = state.leafDataclipIds[0];
} else {
payload.final_state = result;
}

try {
Expand Down
4 changes: 2 additions & 2 deletions packages/ws-worker/test/events/run-complete.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ test('should send a run:complete event with final_dataclip_id for single leaf',
[RUN_LOG]: () => true,
[RUN_COMPLETE]: (evt) => {
t.is(evt.final_dataclip_id, 'clip-1');
t.falsy(evt.final_state);
t.deepEqual(evt.final_state, result);
t.falsy(evt.time);
},
});
Expand Down Expand Up @@ -293,7 +293,7 @@ test('should send final_dataclip_id for a single-leaf workflow', async (t) => {
await handleRunComplete(context, event);

t.is(completeEvent.final_dataclip_id, 'abc-123');
t.falsy(completeEvent.final_state);
t.deepEqual(completeEvent.final_state, finalResult);
t.is(completeEvent.reason, 'success');
});

Expand Down