Fix params2list() duplicate key behavior#2551
Open
ike709 wants to merge 2 commits intoOpenDreamProject:masterfrom
Open
Fix params2list() duplicate key behavior#2551ike709 wants to merge 2 commits intoOpenDreamProject:masterfrom
params2list() duplicate key behavior#2551ike709 wants to merge 2 commits intoOpenDreamProject:masterfrom
Conversation
wixoaGit
requested changes
Apr 5, 2026
ike709
commented
Apr 6, 2026
params2list() duplicate key behaviorparams2list() duplicate key behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At some point BYOND changed duplicate key behavior from "use the last value" to "make a list of all the values".From the ref:
See also #2444 and #2427. This ticks a box on the latter.