add cabinet discovery and configuration#4
Open
PowellTravis wants to merge 1 commit intoOpenCHAMI:mainfrom
Open
add cabinet discovery and configuration#4PowellTravis wants to merge 1 commit intoOpenCHAMI:mainfrom
PowellTravis wants to merge 1 commit intoOpenCHAMI:mainfrom
Conversation
- Extend inventory schema with a top‑level `cabinets[]` list. - Implement `DiscoverCabinets` to extract cabinet xnames from BMC entries, query the Redfish manager (`/Managers/BMC/EthernetInterfaces`) for each cabinet, and populate MAC and IP (fallback to BMC values). - Add `ManagerInfo` and `DiscoverManagerInfo` helpers in the redfish package to retrieve manager Ethernet interface details. - Update `discover` CLI command to invoke cabinet discovery and apply SSH authorized‑key configuration to cabinets (re‑using the same key as for BMCs). - Provide comprehensive unit tests: * `cabinets_test.go` validates Redfish manager discovery. Signed-off-by: Travis Powell <developer.travis@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cabinets[]list.DiscoverCabinetsto extract cabinet xnames from BMC entries, query the Redfish manager (/Managers/BMC/EthernetInterfaces) for each cabinet, and populate MAC and IP (fallback to BMC values).ManagerInfoandDiscoverManagerInfohelpers in the redfish package to retrieve manager Ethernet interface details.discoverCLI command to invoke cabinet discovery and apply SSH authorized‑key configuration to cabinets (re‑using the same key as for BMCs).cabinets_test.govalidates Redfish manager discovery.Pull Request Template
Thank you for your contribution! Please ensure the following before submitting:
Checklist
make test(or equivalent) locally and all tests passgit commit -s) with my real name and email<filename>.licensesidecarLICENSES/directoryDescription
Please include a summary of the change and which issue is fixed.
Also include relevant motivation and context.
Fixes #(issue)
Type of Change
For more info, see Contributing Guidelines.